diff options
author | Adrian McCarthy <amccarth@google.com> | 2016-11-23 16:26:37 +0000 |
---|---|---|
committer | Adrian McCarthy <amccarth@google.com> | 2016-11-23 16:26:37 +0000 |
commit | 4ad5def9b0dbd576d133d038181a56d19589ed12 (patch) | |
tree | 1f41c4d8cf38871c92cb5de55d473e48943cd393 /lldb/source/Plugins/Process/Windows/Live/IDebugDelegate.h | |
parent | 5abf14ba5194059184e3a312369d43fd8006d31e (diff) | |
download | bcm5719-llvm-4ad5def9b0dbd576d133d038181a56d19589ed12.tar.gz bcm5719-llvm-4ad5def9b0dbd576d133d038181a56d19589ed12.zip |
Refactor LLDB's Windows process plugin (NFC)
The Windows process plugin was broken up into multiple pieces a while back in
order to share code between debugging live processes and minidumps
(postmortem) debugging. The minidump portion was replaced by a cross-platform
solution. This left the plugin split into a formerly "common" base classes and
the derived classes for live debugging. This extra layer made the code harder
to understand and work with.
This patch simplifies these class hierarchies by rolling the live debugging
concrete classes up to the base classes. Last week I posted my intent to make
this change to lldb-dev, and I didn't hear any objections.
This involved moving code and changing references to classes like
ProcessWindowsLive to ProcessWindows. It still builds for both 32- and 64-bit,
and the tests still pass on 32-bit. (Tests on 64-bit weren't passing before
this refactor for unrelated reasons.)
llvm-svn: 287770
Diffstat (limited to 'lldb/source/Plugins/Process/Windows/Live/IDebugDelegate.h')
-rw-r--r-- | lldb/source/Plugins/Process/Windows/Live/IDebugDelegate.h | 46 |
1 files changed, 0 insertions, 46 deletions
diff --git a/lldb/source/Plugins/Process/Windows/Live/IDebugDelegate.h b/lldb/source/Plugins/Process/Windows/Live/IDebugDelegate.h deleted file mode 100644 index e88e0ada053..00000000000 --- a/lldb/source/Plugins/Process/Windows/Live/IDebugDelegate.h +++ /dev/null @@ -1,46 +0,0 @@ -//===-- IDebugDelegate.h ----------------------------------------*- C++ -*-===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#ifndef liblldb_Plugins_Process_Windows_IDebugDelegate_H_ -#define liblldb_Plugins_Process_Windows_IDebugDelegate_H_ - -#include "ForwardDecl.h" -#include "lldb/lldb-forward.h" -#include "lldb/lldb-types.h" -#include <string> - -namespace lldb_private { -class Error; -class HostThread; - -//---------------------------------------------------------------------- -// IDebugDelegate -// -// IDebugDelegate defines an interface which allows implementors to receive -// notification of events that happen in a debugged process. -//---------------------------------------------------------------------- -class IDebugDelegate { -public: - virtual ~IDebugDelegate() {} - - virtual void OnExitProcess(uint32_t exit_code) = 0; - virtual void OnDebuggerConnected(lldb::addr_t image_base) = 0; - virtual ExceptionResult OnDebugException(bool first_chance, - const ExceptionRecord &record) = 0; - virtual void OnCreateThread(const HostThread &thread) = 0; - virtual void OnExitThread(lldb::tid_t thread_id, uint32_t exit_code) = 0; - virtual void OnLoadDll(const ModuleSpec &module_spec, - lldb::addr_t module_addr) = 0; - virtual void OnUnloadDll(lldb::addr_t module_addr) = 0; - virtual void OnDebugString(const std::string &string) = 0; - virtual void OnDebuggerError(const Error &error, uint32_t type) = 0; -}; -} - -#endif |