diff options
author | Adrian Prantl <aprantl@apple.com> | 2019-04-05 22:43:42 +0000 |
---|---|---|
committer | Adrian Prantl <aprantl@apple.com> | 2019-04-05 22:43:42 +0000 |
commit | 4c03ea14f2d621807e4d4d9987e5be2615346f9a (patch) | |
tree | a42f5e7ac1cf75a3c5e3b971cd644b557a3f9471 /lldb/source/Plugins/Process/Utility | |
parent | 8f2d1eb9e8879edf743d7db659bb67a66e4170ac (diff) | |
download | bcm5719-llvm-4c03ea14f2d621807e4d4d9987e5be2615346f9a.tar.gz bcm5719-llvm-4c03ea14f2d621807e4d4d9987e5be2615346f9a.zip |
Unify random timeouts throughout LLDB and make them configurable.
Since these timeouts guard against catastrophic error in debugserver,
I also increased all of them to the maximum value among them.
The motivation for this test was the observation that an asanified
LLDB would often exhibit seemingly random test failures that could be
traced back to debugserver packets getting out of sync. With this path
applied I can no longer reproduce the one particular failure mode that
I was investigating.
rdar://problem/49441261
Differential Revision: https://reviews.llvm.org/D60340
llvm-svn: 357829
Diffstat (limited to 'lldb/source/Plugins/Process/Utility')
-rw-r--r-- | lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp b/lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp index 3b40cb322c7..3bf5d9b52a7 100644 --- a/lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp +++ b/lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp @@ -60,7 +60,7 @@ bool lldb_private::InferiorCallMmap(Process *process, addr_t &allocated_addr, options.SetIgnoreBreakpoints(true); options.SetTryAllThreads(true); options.SetDebug(false); - options.SetTimeout(std::chrono::milliseconds(500)); + options.SetTimeout(process->GetUtilityExpressionTimeout()); options.SetTrapExceptions(false); addr_t prot_arg; @@ -148,7 +148,7 @@ bool lldb_private::InferiorCallMunmap(Process *process, addr_t addr, options.SetIgnoreBreakpoints(true); options.SetTryAllThreads(true); options.SetDebug(false); - options.SetTimeout(std::chrono::milliseconds(500)); + options.SetTimeout(process->GetUtilityExpressionTimeout()); options.SetTrapExceptions(false); AddressRange munmap_range; @@ -197,7 +197,7 @@ bool lldb_private::InferiorCall(Process *process, const Address *address, options.SetIgnoreBreakpoints(true); options.SetTryAllThreads(true); options.SetDebug(false); - options.SetTimeout(std::chrono::milliseconds(500)); + options.SetTimeout(process->GetUtilityExpressionTimeout()); options.SetTrapExceptions(trap_exceptions); ClangASTContext *clang_ast_context = |