summaryrefslogtreecommitdiffstats
path: root/lldb/source/Plugins/Process/Utility/UnwindAssemblyProfiler-x86.cpp
diff options
context:
space:
mode:
authorGreg Clayton <gclayton@apple.com>2011-02-09 19:06:17 +0000
committerGreg Clayton <gclayton@apple.com>2011-02-09 19:06:17 +0000
commit1c9e5acd2728823ea60f9c1f2d576b337e2388c2 (patch)
treeb6281e3605f569c181c9ffe318dc8be892288f9c /lldb/source/Plugins/Process/Utility/UnwindAssemblyProfiler-x86.cpp
parent1388a89999022385b2e9145bf3748c56e84ace87 (diff)
downloadbcm5719-llvm-1c9e5acd2728823ea60f9c1f2d576b337e2388c2.tar.gz
bcm5719-llvm-1c9e5acd2728823ea60f9c1f2d576b337e2388c2.zip
Added the DWARF unique type map such that we only create a type once in the
module's AST context. Prior to this fix, with gcc binaries, we end up with a full class definition for any used classes in each compile unit due to the one definition rule. This would result in us making N copies of class T, where N is the number of compile units that use class T, in the module AST. When an expression would then try and use any types that were duplicated, it would quickly confuse clang and make expression evaluation fail due to all of the duplicate types that got copied over. This is now fixed by making a map of types in the DWARF that maps type names to a collection of types + declaration (file + line number) + DIE. Then later when we find a type we look in this module map and find any already cached types that we can just use. 8935777 llvm-svn: 125207
Diffstat (limited to 'lldb/source/Plugins/Process/Utility/UnwindAssemblyProfiler-x86.cpp')
-rw-r--r--lldb/source/Plugins/Process/Utility/UnwindAssemblyProfiler-x86.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/lldb/source/Plugins/Process/Utility/UnwindAssemblyProfiler-x86.cpp b/lldb/source/Plugins/Process/Utility/UnwindAssemblyProfiler-x86.cpp
index fd42948d5db..94b3ae1c8bb 100644
--- a/lldb/source/Plugins/Process/Utility/UnwindAssemblyProfiler-x86.cpp
+++ b/lldb/source/Plugins/Process/Utility/UnwindAssemblyProfiler-x86.cpp
@@ -519,7 +519,6 @@ AssemblyParse_x86::instruction_length (Address addr, int &length)
bool
AssemblyParse_x86::get_non_call_site_unwind_plan (UnwindPlan &unwind_plan)
{
- UnwindPlan up;
UnwindPlan::Row row;
int non_prologue_insn_count = 0;
m_cur_insn = m_func_bounds.GetBaseAddress ();
OpenPOWER on IntegriCloud