diff options
author | Jim Ingham <jingham@apple.com> | 2013-02-15 02:06:30 +0000 |
---|---|---|
committer | Jim Ingham <jingham@apple.com> | 2013-02-15 02:06:30 +0000 |
commit | 299c0c1c09ba8661cf58f8b5b11c5f69975645a5 (patch) | |
tree | 00cd194ba9b0aca69b3216627b559371f7e5ed93 /lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp | |
parent | 5bc0dd79e148171ab054d134189bb9cb37147fec (diff) | |
download | bcm5719-llvm-299c0c1c09ba8661cf58f8b5b11c5f69975645a5.tar.gz bcm5719-llvm-299c0c1c09ba8661cf58f8b5b11c5f69975645a5.zip |
A little cleanup. {Disable/Enable}Breakpoint actually disables/enables BreakpointSites not breakpoints, it is confusing
to have it not named appropriately. Also in StopInfoMachException, we aren't testing for software or not software, just
whether the thing is a breakpoint we set. So don't use "software"...
llvm-svn: 175241
Diffstat (limited to 'lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp')
-rw-r--r-- | lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp b/lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp index 77bc7116b8a..58b6a4e91e4 100644 --- a/lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp +++ b/lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp @@ -345,8 +345,8 @@ StopInfoMachException::CreateStopReasonWithMachException case 6: // EXC_BREAKPOINT { - bool is_software_breakpoint = false; - bool is_trace_if_software_breakpoint_missing = false; + bool is_actual_breakpoint = false; + bool is_trace_if_actual_breakpoint_missing = false; switch (cpu) { case llvm::Triple::x86: @@ -375,9 +375,9 @@ StopInfoMachException::CreateStopReasonWithMachException { // KDP returns EXC_I386_BPTFLT for trace breakpoints if (exc_code == 3) - is_trace_if_software_breakpoint_missing = true; + is_trace_if_actual_breakpoint_missing = true; - is_software_breakpoint = true; + is_actual_breakpoint = true; if (!pc_already_adjusted) pc_decrement = 1; } @@ -385,7 +385,7 @@ StopInfoMachException::CreateStopReasonWithMachException case llvm::Triple::ppc: case llvm::Triple::ppc64: - is_software_breakpoint = exc_code == 1; // EXC_PPC_BREAKPOINT + is_actual_breakpoint = exc_code == 1; // EXC_PPC_BREAKPOINT break; case llvm::Triple::arm: @@ -410,8 +410,8 @@ StopInfoMachException::CreateStopReasonWithMachException } else if (exc_code == 1) // EXC_ARM_BREAKPOINT { - is_software_breakpoint = true; - is_trace_if_software_breakpoint_missing = true; + is_actual_breakpoint = true; + is_trace_if_actual_breakpoint_missing = true; } break; @@ -419,7 +419,7 @@ StopInfoMachException::CreateStopReasonWithMachException break; } - if (is_software_breakpoint) + if (is_actual_breakpoint) { RegisterContextSP reg_ctx_sp (thread.GetRegisterContext()); addr_t pc = reg_ctx_sp->GetPC() - pc_decrement; @@ -447,7 +447,7 @@ StopInfoMachException::CreateStopReasonWithMachException } // Don't call this a trace if we weren't single stepping this thread. - if (is_trace_if_software_breakpoint_missing && thread.GetTemporaryResumeState() == eStateStepping) + if (is_trace_if_actual_breakpoint_missing && thread.GetTemporaryResumeState() == eStateStepping) { return StopInfo::CreateStopReasonToTrace (thread); } |