After we've completed a full backtrace, we'll have one frame which

is "invalid" -- it is past the end of the stack trace.  Add a new
method IsCompletedStackWalk() so we can tell if an invalid stack
frame is from a complete backtrace or if it might be worth re-trying
the last unwind with a different method.

This fixes the unwinder problems Ryan Brown was having with go
programs.  The unwinder can (under the right circumstances) still
destructively replace unwind plans permanently - I'll work on
that in a different patch.  

<rdar://problem/18683658> 

llvm-svn: 221229

1 files changed, 17 insertions, 1 deletions

diff --git a/lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp b/lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp
index 5071b1aa578..88bb608ea9e 100644
--- a/lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp
+++ b/lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp
@@ -62,7 +62,8 @@ RegisterContextLLDB::RegisterContextLLDB
     m_sym_ctx_valid (false),
     m_frame_number (frame_number),
     m_registers(),
-    m_parent_unwind (unwind_lldb)
+    m_parent_unwind (unwind_lldb),
+    m_completed_stack_walk (false)
 {
     m_sym_ctx.Clear(false);
     m_sym_ctx_valid = false;
@@ -306,6 +307,7 @@ RegisterContextLLDB::InitializeNonZerothFrame()
     if (pc == 0)
     {
         m_frame_type = eNotAValidFrame;
+        m_completed_stack_walk = true;
         UnwindLogMsg ("this frame has a pc of 0x0");
         return;
     }
@@ -386,6 +388,10 @@ RegisterContextLLDB::InitializeNonZerothFrame()
                 {
                     UnwindLogMsg ("could not find a valid cfa address");
                     m_frame_type = eNotAValidFrame;
+                    if (cfa_regval == 0 || cfa_regval == 1)
+                    {
+                        m_completed_stack_walk = true;
+                    }
                     return;
                 }
 
@@ -582,6 +588,10 @@ RegisterContextLLDB::InitializeNonZerothFrame()
     {
         UnwindLogMsg ("could not find a valid cfa address");
         m_frame_type = eNotAValidFrame;
+        if (cfa_regval == 0 || cfa_regval == 1)
+        {
+            m_completed_stack_walk = true;
+        }
         return;
     }
 
@@ -1031,6 +1041,12 @@ RegisterContextLLDB::IsValid () const
 }
 
 bool
+RegisterContextLLDB::IsCompletedStackWalk () const
+{
+    return m_completed_stack_walk;
+}
+
+bool
 RegisterContextLLDB::IsTrapHandlerFrame () const
 {
     return m_frame_type == eTrapHandlerFrame;