summaryrefslogtreecommitdiffstats
path: root/lldb/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp
diff options
context:
space:
mode:
authorSaleem Abdulrasool <compnerd@compnerd.org>2014-03-08 20:47:12 +0000
committerSaleem Abdulrasool <compnerd@compnerd.org>2014-03-08 20:47:12 +0000
commit9174593d09f6787704078b65d1fdd3d7476d6884 (patch)
tree2b1dcbf9c08c5f89562ce6d3e69437871eab6397 /lldb/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp
parentd41fca11af4f821b58cb840ce85127c0cb1ff962 (diff)
downloadbcm5719-llvm-9174593d09f6787704078b65d1fdd3d7476d6884.tar.gz
bcm5719-llvm-9174593d09f6787704078b65d1fdd3d7476d6884.zip
POSIX: fix possible API misuse
memcpy cannot be passed NULL. Ensuring that the destination pointer is non-NULL requires checking success. Rather than performing the success check at that point, increasing indentation an additional level, fold it into the previous statement. llvm-svn: 203359
Diffstat (limited to 'lldb/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp')
-rw-r--r--lldb/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/lldb/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp b/lldb/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp
index c446bbfa7dc..3b697abbf21 100644
--- a/lldb/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp
+++ b/lldb/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp
@@ -347,12 +347,12 @@ RegisterContextPOSIXProcessMonitor_x86_64::ReadAllRegisterValues(DataBufferSP &d
if (success)
{
- ::memcpy (dst, &m_gpr_x86_64, GetGPRSize());
- dst += GetGPRSize();
+ ::memcpy (dst, &m_gpr_x86_64, GetGPRSize());
+ dst += GetGPRSize();
+ if (GetFPRType() == eFXSAVE)
+ ::memcpy (dst, &m_fpr.xstate.fxsave, sizeof(m_fpr.xstate.fxsave));
}
- if (GetFPRType() == eFXSAVE)
- ::memcpy (dst, &m_fpr.xstate.fxsave, sizeof(m_fpr.xstate.fxsave));
-
+
if (GetFPRType() == eXSAVE)
{
ByteOrder byte_order = GetByteOrder();
OpenPOWER on IntegriCloud