summaryrefslogtreecommitdiffstats
path: root/lldb/source/Plugins/Process/MacOSX-Kernel
diff options
context:
space:
mode:
authorHal Finkel <hfinkel@anl.gov>2014-10-06 20:19:47 +0000
committerHal Finkel <hfinkel@anl.gov>2014-10-06 20:19:47 +0000
commit98085953192ef6491c858e14e330b2f1324ff2ba (patch)
tree8aabb8325d9bddafd370f05d2d37760e8a9e3f46 /lldb/source/Plugins/Process/MacOSX-Kernel
parentcfc922996615b5756b110aea77c473f8bd2eeca8 (diff)
downloadbcm5719-llvm-98085953192ef6491c858e14e330b2f1324ff2ba.tar.gz
bcm5719-llvm-98085953192ef6491c858e14e330b2f1324ff2ba.zip
[DAGCombine] Remove SIGN_EXTEND-related inf-loop
The patch's author points out that, despite the function's documentation, getSetCCResultType is only used to get the SETCC result type (with one here-removed problematic exception). In one case, getSetCCResultType was being used to get the predicate type to use for a SELECT node, and then SIGN_EXTENDing (or truncating) to get the input predicate to match that type. Unfortunately, this was happening inside visitSIGN_EXTEND, and creating new SIGN_EXTEND nodes was causing an infinite loop. In addition, this behavior was wrong if a target was not using ZeroOrNegativeOneBooleanContent. Lastly, the extension/truncation seems unnecessary here: SELECT is defined as: Select(COND, TRUEVAL, FALSEVAL). If the type of the boolean COND is not i1 then the high bits must conform to getBooleanContents. So here we remove this use of getSetCCResultType and update getSetCCResultType's documentation to reflect its actual uses. Patch by deadal nix! llvm-svn: 219141
Diffstat (limited to 'lldb/source/Plugins/Process/MacOSX-Kernel')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud