diff options
author | Pavel Labath <labath@google.com> | 2017-02-06 21:46:22 +0000 |
---|---|---|
committer | Pavel Labath <labath@google.com> | 2017-02-06 21:46:22 +0000 |
commit | 250858a01e6dc70e885282b043d22f4f6880be31 (patch) | |
tree | 0e793dcb60b86346121abfe44970cfe91e1afa43 /lldb/source/Plugins/Process/MacOSX-Kernel | |
parent | 0e92fbb59c980fc89564248d8422ce58fa475f10 (diff) | |
download | bcm5719-llvm-250858a01e6dc70e885282b043d22f4f6880be31.tar.gz bcm5719-llvm-250858a01e6dc70e885282b043d22f4f6880be31.zip |
Remove verbose category in the kdp channel
llvm-svn: 294244
Diffstat (limited to 'lldb/source/Plugins/Process/MacOSX-Kernel')
4 files changed, 7 insertions, 14 deletions
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp b/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp index 43e4617feaf..23a29c3fdd5 100644 --- a/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp +++ b/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp @@ -200,8 +200,7 @@ size_t CommunicationKDP::WaitForPacketWithTimeoutMicroSecondsNoLock( uint8_t buffer[8192]; Error error; - Log *log(ProcessKDPLog::GetLogIfAllCategoriesSet(KDP_LOG_PACKETS | - KDP_LOG_VERBOSE)); + Log *log(ProcessKDPLog::GetLogIfAllCategoriesSet(KDP_LOG_PACKETS)); // Check for a packet from our cache first without trying any reading... if (CheckForPacket(NULL, 0, packet)) @@ -216,12 +215,12 @@ size_t CommunicationKDP::WaitForPacketWithTimeoutMicroSecondsNoLock( : std::chrono::microseconds(timeout_usec), status, &error); - if (log) - log->Printf("%s: Read (buffer, (sizeof(buffer), timeout_usec = 0x%x, " - "status = %s, error = %s) => bytes_read = %" PRIu64, - LLVM_PRETTY_FUNCTION, timeout_usec, + LLDB_LOGV(log, + "Read (buffer, sizeof(buffer), timeout_usec = 0x{0:x}, " + "status = {1}, error = {2}) => bytes_read = {4}", + timeout_usec, Communication::ConnectionStatusAsCString(status), - error.AsCString(), (uint64_t)bytes_read); + error, bytes_read); if (bytes_read > 0) { if (CheckForPacket(buffer, bytes_read, packet)) diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp index 121418dad5d..27f742861d3 100644 --- a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp +++ b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp @@ -518,8 +518,7 @@ bool ProcessKDP::UpdateThreadList(ThreadList &old_thread_list, ThreadList &new_thread_list) { // locker will keep a mutex locked until it goes out of scope Log *log(ProcessKDPLog::GetLogIfAllCategoriesSet(KDP_LOG_THREAD)); - if (log && log->GetMask().Test(KDP_LOG_VERBOSE)) - log->Printf("ProcessKDP::%s (pid = %" PRIu64 ")", __FUNCTION__, GetID()); + LLDB_LOGV(log, "pid = {0}", GetID()); // Even though there is a CPU mask, it doesn't mean we can see each CPU // individually, there is really only one. Lets call this thread 1. diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.cpp b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.cpp index 479f09aa898..74f45059561 100644 --- a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.cpp +++ b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.cpp @@ -73,8 +73,6 @@ void ProcessKDPLog::DisableLog(const char **categories, Stream *feedback_strm) { flag_bits &= ~KDP_LOG_STEP; else if (::strcasecmp(arg, "thread") == 0) flag_bits &= ~KDP_LOG_THREAD; - else if (::strcasecmp(arg, "verbose") == 0) - flag_bits &= ~KDP_LOG_VERBOSE; else if (::strncasecmp(arg, "watch", 5) == 0) flag_bits &= ~KDP_LOG_WATCHPOINTS; else { @@ -138,8 +136,6 @@ Log *ProcessKDPLog::EnableLog(StreamSP &log_stream_sp, uint32_t log_options, flag_bits |= KDP_LOG_STEP; else if (::strcasecmp(arg, "thread") == 0) flag_bits |= KDP_LOG_THREAD; - else if (::strcasecmp(arg, "verbose") == 0) - flag_bits |= KDP_LOG_VERBOSE; else if (::strncasecmp(arg, "watch", 5) == 0) flag_bits |= KDP_LOG_WATCHPOINTS; else { diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.h b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.h index 703c775268d..4408b145951 100644 --- a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.h +++ b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.h @@ -17,7 +17,6 @@ // Project includes #include "lldb/Core/Log.h" -#define KDP_LOG_VERBOSE (1u << 0) #define KDP_LOG_PROCESS (1u << 1) #define KDP_LOG_THREAD (1u << 2) #define KDP_LOG_PACKETS (1u << 3) |