diff options
author | Bruce Mitchener <bruce.mitchener@gmail.com> | 2015-10-01 07:47:38 +0000 |
---|---|---|
committer | Bruce Mitchener <bruce.mitchener@gmail.com> | 2015-10-01 07:47:38 +0000 |
commit | 852cb7fb0d9467ca6349602196d75fdf1ccade37 (patch) | |
tree | 243112b69a612e338f6f2921b7efcefcef88f95a /lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp | |
parent | c32c277b84247c9b68ab9ee9423ed372334f85fd (diff) | |
download | bcm5719-llvm-852cb7fb0d9467ca6349602196d75fdf1ccade37.tar.gz bcm5719-llvm-852cb7fb0d9467ca6349602196d75fdf1ccade37.zip |
Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator
Summary:
Previously `CMAKE_BUILD_TYPE` was used to determine whether to link in `python27.lib` or `python27_d.lib`, unfortunately this only works reliably when using a CMake generator that generates a single build configuration (e.g. Ninja). The Visual Studio CMake generator generates four build configurations at once (`Debug`, `Release`, `RelWithDebInfo`, `MinSizeRel`), so if `CMAKE_BUILD_TYPE` is set to `Debug` all four build configurations end up linking in `python27_d.lib`, this is clearly undesirable.
To ensure that the correct Python lib is used for each build configuration the value of `PYTHON_LIBRARY` is now determined using generator expressions that evaluate to either the debug or release Python lib. The values of `PYTHON_EXECUTABLE` and `PYTHON_DLL` are now likewise determined using generator expressions.
Note that these changes only apply to the Windows build.
Patch by Vadim Macagon. Thanks!
Reviewers: zturner, brucem
Subscribers: zturner, lldb-commits
Differential Revision: http://reviews.llvm.org/D13234
llvm-svn: 248991
Diffstat (limited to 'lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp')
0 files changed, 0 insertions, 0 deletions