diff options
author | Pavel Labath <pavel@labath.sk> | 2019-07-01 13:18:19 +0000 |
---|---|---|
committer | Pavel Labath <pavel@labath.sk> | 2019-07-01 13:18:19 +0000 |
commit | c12dfcf1f56ba06589f63f49d256efeb38b3e8d5 (patch) | |
tree | 9b82aac3be0979ce367cdfd53ec81ec0d31ece89 /lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp | |
parent | 77c04c3a5774595d994aa8c521752c5f3b273a0a (diff) | |
download | bcm5719-llvm-c12dfcf1f56ba06589f63f49d256efeb38b3e8d5.tar.gz bcm5719-llvm-c12dfcf1f56ba06589f63f49d256efeb38b3e8d5.zip |
Don't check the validity of newly contructed data buffers
A bunch of places were checking that DataBufferHeap::GetBytes returns a
non-null pointer right after constructing it. The only time when
GetBytes returns a null pointer is if it is empty (and I'm not sure that
even this is a good idea), but that is clearly not the case here, as the
buffer was constructed with a non-zero size just a couple of lines back.
llvm-svn: 364754
Diffstat (limited to 'lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp')
-rw-r--r-- | lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp index 3a232e054d1..9bb9e6b77ec 100644 --- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp +++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp @@ -286,13 +286,6 @@ Status NativeRegisterContextLinux_arm64::ReadAllRegisterValues( return error; uint8_t *dst = data_sp->GetBytes(); - if (dst == nullptr) { - error.SetErrorStringWithFormat("DataBufferHeap instance of size %" PRIu64 - " returned a null pointer", - REG_CONTEXT_SIZE); - return error; - } - ::memcpy(dst, &m_gpr_arm64, GetGPRSize()); dst += GetGPRSize(); ::memcpy(dst, &m_fpr, sizeof(m_fpr)); |