diff options
author | Adrian Prantl <aprantl@apple.com> | 2019-01-15 18:07:52 +0000 |
---|---|---|
committer | Adrian Prantl <aprantl@apple.com> | 2019-01-15 18:07:52 +0000 |
commit | d963a7c39891ae33e87500502d5199946af22bde (patch) | |
tree | 1a5d123b49e1e9e039a62b08a9011cb91560883f /lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp | |
parent | 5e54bc18e27b7fa2af240ff93f1771faa425c319 (diff) | |
download | bcm5719-llvm-d963a7c39891ae33e87500502d5199946af22bde.tar.gz bcm5719-llvm-d963a7c39891ae33e87500502d5199946af22bde.zip |
Make CompilerType::getBitSize() / getByteSize() return an optional result. NFC
The code in LLDB assumes that CompilerType and friends use the size 0
as a sentinel value to signal an error. This works for C++, where no
zero-sized type exists, but in many other programming languages
(including I believe C) types of size zero are possible and even
common. This is a particular pain point in swift-lldb, where extra
code exists to double-check that a type is *really* of size zero and
not an error at various locations.
To remedy this situation, this patch starts by converting
CompilerType::getBitSize() and getByteSize() to return an optional
result. To avoid wasting space, I hand-rolled my own optional data
type assuming that no type is larger than what fits into 63
bits. Follow-up patches would make similar changes to the ValueObject
hierarchy.
rdar://problem/47178964
Differential Revision: https://reviews.llvm.org/D56688
llvm-svn: 351214
Diffstat (limited to 'lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp')
0 files changed, 0 insertions, 0 deletions