Make the Error class constructor protected

This is forcing to use Error::success(), which is in a wide majority
of cases a lot more readable.

Differential Revision: https://reviews.llvm.org/D26481

llvm-svn: 286561

1 files changed, 4 insertions, 4 deletions

diff --git a/lldb/source/Plugins/Platform/Android/AdbClient.cpp b/lldb/source/Plugins/Platform/Android/AdbClient.cpp
index 79ad8f52d64..592bc84f590 100644
--- a/lldb/source/Plugins/Platform/Android/AdbClient.cpp
+++ b/lldb/source/Plugins/Platform/Android/AdbClient.cpp
@@ -381,7 +381,7 @@ Error AdbClient::internalShell(const char *command, uint32_t timeout_ms,
                    std::string(output_buf.begin(), output_buf.end()).c_str());
   }
 
-  return Error();
+  return Error::success();
 }
 
 Error AdbClient::Shell(const char *command, uint32_t timeout_ms,
@@ -412,7 +412,7 @@ Error AdbClient::ShellToFile(const char *command, uint32_t timeout_ms,
   dst.close();
   if (!dst)
     return Error("Failed to write file %s", output_filename.c_str());
-  return Error();
+  return Error::success();
 }
 
 std::unique_ptr<AdbClient::SyncService>
@@ -536,7 +536,7 @@ Error AdbClient::SyncService::internalStat(const FileSpec &remote_file,
   mode = extractor.GetU32(&offset);
   size = extractor.GetU32(&offset);
   mtime = extractor.GetU32(&offset);
-  return Error();
+  return Error::success();
 }
 
 Error AdbClient::SyncService::PullFile(const FileSpec &remote_file,
@@ -641,7 +641,7 @@ Error AdbClient::SyncService::PullFileChunk(std::vector<char> &buffer,
   } else
     return Error("Pull failed with unknown response: %s", response_id.c_str());
 
-  return Error();
+  return Error::success();
 }
 
 Error AdbClient::SyncService::ReadAllBytes(void *buffer, size_t size) {