summaryrefslogtreecommitdiffstats
path: root/lldb/source/Plugins/Platform/Android
diff options
context:
space:
mode:
authorZachary Turner <zturner@google.com>2016-11-17 21:15:14 +0000
committerZachary Turner <zturner@google.com>2016-11-17 21:15:14 +0000
commit3165945a419e4882b94f73f005f9ea4d3d10a985 (patch)
treef8ecba9330545a9f0fa01053d2d237c46d85319f /lldb/source/Plugins/Platform/Android
parentca9d83475e94b3b1649f6f76b4cd6c345ea0404b (diff)
downloadbcm5719-llvm-3165945a419e4882b94f73f005f9ea4d3d10a985.tar.gz
bcm5719-llvm-3165945a419e4882b94f73f005f9ea4d3d10a985.zip
Convert Platform, Process, and Connection functions to StringRef.
All tests pass on Linux and Windows. llvm-svn: 287259
Diffstat (limited to 'lldb/source/Plugins/Platform/Android')
-rw-r--r--lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp9
-rw-r--r--lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h4
2 files changed, 7 insertions, 6 deletions
diff --git a/lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp b/lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
index 288accfe871..cabb3ffb1c1 100644
--- a/lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
+++ b/lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
@@ -203,7 +203,7 @@ Error PlatformAndroidRemoteGDBServer::MakeConnectURL(
}
lldb::ProcessSP PlatformAndroidRemoteGDBServer::ConnectProcess(
- const char *connect_url, const char *plugin_name,
+ llvm::StringRef connect_url, llvm::StringRef plugin_name,
lldb_private::Debugger &debugger, lldb_private::Target *target,
lldb_private::Error &error) {
// We don't have the pid of the remote gdbserver when it isn't started by us
@@ -216,7 +216,8 @@ lldb::ProcessSP PlatformAndroidRemoteGDBServer::ConnectProcess(
int remote_port;
llvm::StringRef scheme, host, path;
if (!UriParser::Parse(connect_url, scheme, host, remote_port, path)) {
- error.SetErrorStringWithFormat("Invalid URL: %s", connect_url);
+ error.SetErrorStringWithFormat("Invalid URL: %s",
+ connect_url.str().c_str());
return nullptr;
}
@@ -227,6 +228,6 @@ lldb::ProcessSP PlatformAndroidRemoteGDBServer::ConnectProcess(
if (error.Fail())
return nullptr;
- return PlatformRemoteGDBServer::ConnectProcess(
- new_connect_url.c_str(), plugin_name, debugger, target, error);
+ return PlatformRemoteGDBServer::ConnectProcess(new_connect_url, plugin_name,
+ debugger, target, error);
}
diff --git a/lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h b/lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h
index f9593fa8e80..6d5bfecd993 100644
--- a/lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h
+++ b/lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h
@@ -37,8 +37,8 @@ public:
Error DisconnectRemote() override;
- lldb::ProcessSP ConnectProcess(const char *connect_url,
- const char *plugin_name,
+ lldb::ProcessSP ConnectProcess(llvm::StringRef connect_url,
+ llvm::StringRef plugin_name,
lldb_private::Debugger &debugger,
lldb_private::Target *target,
lldb_private::Error &error) override;
OpenPOWER on IntegriCloud