Revert r251578. I was in the middle of editing the commit message

and decided to not commit the change, but accidentally committed
it anyway.

This was based on a static analysis complaint; it thought there
was a code path where AdbClient::PushFile would call AdbClient::ReadSyncHeader
and AdbClient::ReadSyncHeader wouldn't set data_len.  But in that
case, the Error object returned will be Fail and we won't use
the data_len or response_id contents.

llvm-svn: 251580

1 files changed, 1 insertions, 1 deletions

diff --git a/lldb/source/Plugins/Platform/Android/AdbClient.cpp b/lldb/source/Plugins/Platform/Android/AdbClient.cpp
index 9d18011e0c4..f57e8c3faf2 100644
--- a/lldb/source/Plugins/Platform/Android/AdbClient.cpp
+++ b/lldb/source/Plugins/Platform/Android/AdbClient.cpp
@@ -359,7 +359,7 @@ AdbClient::PushFile (const FileSpec &local_file, const FileSpec &remote_file)
         return error;
 
     std::string response_id;
-    uint32_t data_len = 0;
+    uint32_t data_len;
     error = ReadSyncHeader (response_id, data_len);
     if (error.Fail ())
         return Error ("Failed to read DONE response: %s", error.AsCString ());