diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2019-02-12 03:47:39 +0000 |
---|---|---|
committer | Jonas Devlieghere <jonas@devlieghere.com> | 2019-02-12 03:47:39 +0000 |
commit | 70355ace3f075553043f6715390891633afc604e (patch) | |
tree | 34766a2eb6a35778deaf172f8b0017ff4ced93b2 /lldb/source/Plugins/ObjectFile | |
parent | 2b9a8f37a484aa7f976829c055147f20b82d39d9 (diff) | |
download | bcm5719-llvm-70355ace3f075553043f6715390891633afc604e.tar.gz bcm5719-llvm-70355ace3f075553043f6715390891633afc604e.zip |
Remove redundant ::get() for smart pointer. (NFC)
This commit removes redundant calls to smart pointer’s ::get() method.
https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-smartptr-get.html
llvm-svn: 353795
Diffstat (limited to 'lldb/source/Plugins/ObjectFile')
4 files changed, 9 insertions, 9 deletions
diff --git a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp index 521e8750858..eaafa84db03 100644 --- a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp +++ b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp @@ -1057,7 +1057,7 @@ Address ObjectFileELF::GetBaseAddress() { // ParseDependentModules //---------------------------------------------------------------------- size_t ObjectFileELF::ParseDependentModules() { - if (m_filespec_ap.get()) + if (m_filespec_ap) return m_filespec_ap->GetSize(); m_filespec_ap.reset(new FileSpecList()); @@ -2805,7 +2805,7 @@ Symtab *ObjectFileELF::GetSymtab() { if (module_obj_file && module_obj_file != this) return module_obj_file->GetSymtab(); - if (m_symtab_ap.get() == NULL) { + if (m_symtab_ap == NULL) { SectionList *section_list = module_sp->GetSectionList(); if (!section_list) return NULL; diff --git a/lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp b/lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp index ec5500622a4..46daa5e9c21 100644 --- a/lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp +++ b/lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp @@ -115,7 +115,7 @@ Symtab *ObjectFileJIT::GetSymtab() { ModuleSP module_sp(GetModule()); if (module_sp) { std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex()); - if (m_symtab_ap.get() == NULL) { + if (m_symtab_ap == NULL) { m_symtab_ap.reset(new Symtab(this)); std::lock_guard<std::recursive_mutex> symtab_guard( m_symtab_ap->GetMutex()); @@ -134,7 +134,7 @@ bool ObjectFileJIT::IsStripped() { } void ObjectFileJIT::CreateSections(SectionList &unified_section_list) { - if (!m_sections_ap.get()) { + if (!m_sections_ap) { m_sections_ap.reset(new SectionList()); ObjectFileJITDelegateSP delegate_sp(m_delegate_wp.lock()); if (delegate_sp) { @@ -161,7 +161,7 @@ void ObjectFileJIT::Dump(Stream *s) { if (sections) sections->Dump(s, NULL, true, UINT32_MAX); - if (m_symtab_ap.get()) + if (m_symtab_ap) m_symtab_ap->Dump(s, NULL, eSortOrderNone); } } diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp index dc583815d65..22839990da8 100644 --- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp +++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp @@ -1312,7 +1312,7 @@ Symtab *ObjectFileMachO::GetSymtab() { ModuleSP module_sp(GetModule()); if (module_sp) { std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex()); - if (m_symtab_ap.get() == NULL) { + if (m_symtab_ap == NULL) { m_symtab_ap.reset(new Symtab(this)); std::lock_guard<std::recursive_mutex> symtab_guard( m_symtab_ap->GetMutex()); @@ -4842,7 +4842,7 @@ void ObjectFileMachO::Dump(Stream *s) { if (sections) sections->Dump(s, NULL, true, UINT32_MAX); - if (m_symtab_ap.get()) + if (m_symtab_ap) m_symtab_ap->Dump(s, NULL, eSortOrderNone); } } diff --git a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp index dc7f61068a5..5ad6abe4d22 100644 --- a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp +++ b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp @@ -552,7 +552,7 @@ Symtab *ObjectFilePECOFF::GetSymtab() { ModuleSP module_sp(GetModule()); if (module_sp) { std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex()); - if (m_symtab_ap.get() == NULL) { + if (m_symtab_ap == NULL) { SectionList *sect_list = GetSectionList(); m_symtab_ap.reset(new Symtab(this)); std::lock_guard<std::recursive_mutex> guard(m_symtab_ap->GetMutex()); @@ -948,7 +948,7 @@ void ObjectFilePECOFF::Dump(Stream *s) { if (sections) sections->Dump(s, NULL, true, UINT32_MAX); - if (m_symtab_ap.get()) + if (m_symtab_ap) m_symtab_ap->Dump(s, NULL, eSortOrderNone); if (m_dos_header.e_magic) |