Fix Clang-tidy modernize-use-override warnings in source/Plugins/ObjectContainer and ObjectFile; other minor fixes.

llvm-svn: 251119

1 files changed, 52 insertions, 50 deletions

diff --git a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
index eb8d9e75189..1c7fefcf5de 100644
--- a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
+++ b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
@@ -10,8 +10,12 @@
 #ifndef liblldb_ObjectFilePECOFF_h_
 #define liblldb_ObjectFilePECOFF_h_
 
+// C Includes
+// C++ Includes
 #include <vector>
 
+// Other libraries and framework includes
+// Project includes
 #include "lldb/Symbol/ObjectFile.h"
 
 class ObjectFilePECOFF : 
@@ -44,6 +48,15 @@ public:
         MachineWcemIpsv2 = 0x169
     } MachineType;
     
+    ObjectFilePECOFF(const lldb::ModuleSP &module_sp,
+                     lldb::DataBufferSP& data_sp,
+                     lldb::offset_t data_offset,
+                     const lldb_private::FileSpec* file,
+                     lldb::offset_t file_offset,
+                     lldb::offset_t length);
+
+    ~ObjectFilePECOFF() override;
+
     //------------------------------------------------------------------
     // Static Functions
     //------------------------------------------------------------------
@@ -84,74 +97,63 @@ public:
     static bool
     MagicBytesMatch (lldb::DataBufferSP& data_sp);
     
+    bool
+    ParseHeader() override;
     
-    ObjectFilePECOFF (const lldb::ModuleSP &module_sp,
-                      lldb::DataBufferSP& data_sp,
-                      lldb::offset_t data_offset,
-                      const lldb_private::FileSpec* file,
-                      lldb::offset_t file_offset,
-                      lldb::offset_t length);
-    
-	virtual 
-    ~ObjectFilePECOFF();
-    
-    virtual bool
-    ParseHeader ();
-    
-    virtual bool
-    SetLoadAddress(lldb_private::Target &target, lldb::addr_t value, bool value_is_offset);
+    bool
+    SetLoadAddress(lldb_private::Target &target, lldb::addr_t value, bool value_is_offset) override;
 
-    virtual lldb::ByteOrder
-    GetByteOrder () const;
+    lldb::ByteOrder
+    GetByteOrder() const override;
     
-    virtual bool
-    IsExecutable () const;
+    bool
+    IsExecutable() const override;
     
-    virtual uint32_t
-    GetAddressByteSize ()  const;
+    uint32_t
+    GetAddressByteSize() const override;
     
 //    virtual lldb_private::AddressClass
 //    GetAddressClass (lldb::addr_t file_addr);
-//    
-    virtual lldb_private::Symtab *
-    GetSymtab ();
+
+    lldb_private::Symtab *
+    GetSymtab() override;
     
-    virtual bool
-    IsStripped ();
+    bool
+    IsStripped() override;
 
-    virtual void
-    CreateSections (lldb_private::SectionList &unified_section_list);
+    void
+    CreateSections(lldb_private::SectionList &unified_section_list) override;
     
-    virtual void
-    Dump (lldb_private::Stream *s);
+    void
+    Dump(lldb_private::Stream *s) override;
     
-    virtual bool
-    GetArchitecture (lldb_private::ArchSpec &arch);
+    bool
+    GetArchitecture(lldb_private::ArchSpec &arch) override;
     
-    virtual bool
-    GetUUID (lldb_private::UUID* uuid);
+    bool
+    GetUUID(lldb_private::UUID* uuid) override;
     
-    virtual uint32_t
-    GetDependentModules (lldb_private::FileSpecList& files);
+    uint32_t
+    GetDependentModules(lldb_private::FileSpecList& files) override;
     
-    //------------------------------------------------------------------
-    // PluginInterface protocol
-    //------------------------------------------------------------------
-    virtual lldb_private::ConstString
-    GetPluginName();
-    
-    virtual uint32_t
-    GetPluginVersion();
-//    
 //    virtual lldb_private::Address
 //    GetEntryPointAddress ();
     
-    virtual ObjectFile::Type
-    CalculateType();
+    ObjectFile::Type
+    CalculateType() override;
     
-    virtual ObjectFile::Strata
-    CalculateStrata();
+    ObjectFile::Strata
+    CalculateStrata() override;
     
+    //------------------------------------------------------------------
+    // PluginInterface protocol
+    //------------------------------------------------------------------
+    lldb_private::ConstString
+    GetPluginName() override;
+    
+    uint32_t
+    GetPluginVersion() override;
+
 protected:
 	bool NeedsEndianSwap() const;    
     
@@ -293,4 +295,4 @@ private:
     lldb::addr_t		m_image_base;
 };
 
-#endif  // #ifndef liblldb_ObjectFilePECOFF_h_
+#endif // liblldb_ObjectFilePECOFF_h_