Don't allow direct access to StreamString's internal buffer.

This is a large API change that removes the two functions from
StreamString that return a std::string& and a const std::string&,
and instead provide one function which returns a StringRef.

Direct access to the underlying buffer violates the concept of
a "stream" which is intended to provide forward only access,
and makes porting to llvm::raw_ostream more difficult in the
future.

Differential Revision: https://reviews.llvm.org/D26698

llvm-svn: 287152

1 files changed, 2 insertions, 1 deletions

diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index 45d3b123a54..9ef4e9c3c9b 100644
--- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -5996,7 +5996,8 @@ bool ObjectFileMachO::SaveCore(const lldb::ProcessSP &process_sp,
             const size_t LC_THREAD_data_size = LC_THREAD_data.GetSize();
             buffer.PutHex32(LC_THREAD);
             buffer.PutHex32(8 + LC_THREAD_data_size); // cmd + cmdsize + data
-            buffer.Write(LC_THREAD_data.GetData(), LC_THREAD_data_size);
+            buffer.Write(LC_THREAD_data.GetString().data(),
+                         LC_THREAD_data_size);
           }
 
           // Write out all of the segment load commands