summaryrefslogtreecommitdiffstats
path: root/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
diff options
context:
space:
mode:
authorJonas Devlieghere <jonas@devlieghere.com>2019-04-10 20:48:55 +0000
committerJonas Devlieghere <jonas@devlieghere.com>2019-04-10 20:48:55 +0000
commit8b3af63b8993e45b1783853a3fcf6f36bfbed81b (patch)
tree41759d08361beda32b90e345d8033aecd2e15088 /lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
parent66b6bb1766b3e5eea56b26fc91d03f1fccbe15e4 (diff)
downloadbcm5719-llvm-8b3af63b8993e45b1783853a3fcf6f36bfbed81b.tar.gz
bcm5719-llvm-8b3af63b8993e45b1783853a3fcf6f36bfbed81b.zip
[NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
Diffstat (limited to 'lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp')
-rw-r--r--lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp14
1 files changed, 0 insertions, 14 deletions
diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index bdc4e19c3e6..b6db8d77a26 100644
--- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -3104,9 +3104,7 @@ size_t ObjectFileMachO::ParseSymtab() {
type = eSymbolTypeLocal;
break;
- //----------------------------------------------------------------------
// INCL scopes
- //----------------------------------------------------------------------
case N_BINCL:
// include file beginning: name,,NO_SECT,0,sum We use
// the current number of symbols in the symbol table
@@ -3167,9 +3165,7 @@ size_t ObjectFileMachO::ParseSymtab() {
type = eSymbolTypeLineEntry;
break;
- //----------------------------------------------------------------------
// Left and Right Braces
- //----------------------------------------------------------------------
case N_LBRAC:
// left bracket: 0,,NO_SECT,nesting level,address We
// use the current number of symbols in the symbol
@@ -3204,9 +3200,7 @@ size_t ObjectFileMachO::ParseSymtab() {
type = eSymbolTypeHeaderFile;
break;
- //----------------------------------------------------------------------
// COMM scopes
- //----------------------------------------------------------------------
case N_BCOMM:
// begin common: name,,NO_SECT,0,0
// We use the current number of symbols in the symbol
@@ -4052,9 +4046,7 @@ size_t ObjectFileMachO::ParseSymtab() {
type = eSymbolTypeLocal;
break;
- //----------------------------------------------------------------------
// INCL scopes
- //----------------------------------------------------------------------
case N_BINCL:
// include file beginning: name,,NO_SECT,0,sum We use the current
// number of symbols in the symbol table in lieu of using nlist_idx
@@ -4112,9 +4104,7 @@ size_t ObjectFileMachO::ParseSymtab() {
type = eSymbolTypeLineEntry;
break;
- //----------------------------------------------------------------------
// Left and Right Braces
- //----------------------------------------------------------------------
case N_LBRAC:
// left bracket: 0,,NO_SECT,nesting level,address We use the
// current number of symbols in the symbol table in lieu of using
@@ -4146,9 +4136,7 @@ size_t ObjectFileMachO::ParseSymtab() {
type = eSymbolTypeHeaderFile;
break;
- //----------------------------------------------------------------------
// COMM scopes
- //----------------------------------------------------------------------
case N_BCOMM:
// begin common: name,,NO_SECT,0,0
// We use the current number of symbols in the symbol table in lieu
@@ -5966,9 +5954,7 @@ bool ObjectFileMachO::AllowAssemblyEmulationUnwindPlans() {
return m_allow_assembly_emulation_unwind_plans;
}
-//------------------------------------------------------------------
// PluginInterface protocol
-//------------------------------------------------------------------
lldb_private::ConstString ObjectFileMachO::GetPluginName() {
return GetPluginNameStatic();
}
OpenPOWER on IntegriCloud