summaryrefslogtreecommitdiffstats
path: root/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
diff options
context:
space:
mode:
authorKonrad Kleine <kkleine@redhat.com>2019-09-11 14:33:21 +0000
committerKonrad Kleine <kkleine@redhat.com>2019-09-11 14:33:21 +0000
commitd44c4a71df9d6294c944542598ec1085cd4d5add (patch)
treec578e8bd91015f93006f06cf020da2feea7156b8 /lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
parent3ad8278737d042c6b5b61c0143ee68db66be91fe (diff)
downloadbcm5719-llvm-d44c4a71df9d6294c944542598ec1085cd4d5add.tar.gz
bcm5719-llvm-d44c4a71df9d6294c944542598ec1085cd4d5add.zip
Revert "[LLDB][ELF] Fixup for comments in D67390"
This reverts commit 813f05915d29904878d926f9849ca3dbe78096af. llvm-svn: 371624
Diffstat (limited to 'lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp')
-rw-r--r--lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp11
1 files changed, 6 insertions, 5 deletions
diff --git a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
index e1f08ffaa18..20e26f033d1 100644
--- a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
+++ b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
@@ -2644,11 +2644,12 @@ Symtab *ObjectFileELF::GetSymtab() {
// Sharable objects and dynamic executables usually have 2 distinct symbol
// tables, one named ".symtab", and the other ".dynsym". The dynsym is a
- // smaller version of the symtab that only contains global symbols.
- // Information in the dynsym section is *usually* also found in the symtab,
- // but this is not required as symtab entries can be removed after linking.
- // The minidebuginfo format makes use of this facility to create smaller
- // symbol tables.
+ // smaller version of the symtab that only contains global symbols. The
+ // information found in the dynsym is therefore also found in the symtab,
+ // while the reverse is not necessarily true.
+ // One exception to the above rule is when we have minidebuginfo embedded
+ // into a compressed .gnu_debugdata section. This section contains a .symtab
+ // from which all symbols already contained in the .dynsym are stripped.
Section *symtab =
section_list->FindSectionByType(eSectionTypeELFSymbolTable, true).get();
if (symtab) {
OpenPOWER on IntegriCloud