diff options
author | Tamas Berghammer <tberghammer@google.com> | 2016-07-04 13:31:57 +0000 |
---|---|---|
committer | Tamas Berghammer <tberghammer@google.com> | 2016-07-04 13:31:57 +0000 |
commit | c662533d0509e574a76926226bea7d667172fa9e (patch) | |
tree | 6fd46d3e09007821502a54956d3e807305b27b21 /lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp | |
parent | 140b8d1ecdd3c851322b4d4ded6ac443cb109825 (diff) | |
download | bcm5719-llvm-c662533d0509e574a76926226bea7d667172fa9e.tar.gz bcm5719-llvm-c662533d0509e574a76926226bea7d667172fa9e.zip |
Ignore oatdata and oatexec symbols more widely
These are artifical symbols inside android oat files without any value
for the user while causing a significant perfoamce hit inside the
unwinder. We were already ignoring it inside system@framework@boot.oat
bot they have to be ignored in every oat file. Considering that oat
files are only used on android this have no effect on any other
platfrom.
llvm-svn: 274500
Diffstat (limited to 'lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp')
-rw-r--r-- | lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp index eb477c4c582..f2297d431c7 100644 --- a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp +++ b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp @@ -2184,15 +2184,15 @@ ObjectFileELF::ParseSymbols (Symtab *symtab, static ConstString bss_section_name(".bss"); static ConstString opd_section_name(".opd"); // For ppc64 - // On Android the oatdata and the oatexec symbols in system@framework@boot.oat covers the full - // .text section what causes issues with displaying unusable symbol name to the user and very - // slow unwinding speed because the instruction emulation based unwind plans try to emulate all + // On Android the oatdata and the oatexec symbols in the oat files covers the full .text + // section what causes issues with displaying unusable symbol name to the user and very slow + // unwinding speed because the instruction emulation based unwind plans try to emulate all // instructions in these symbols. Don't add these symbols to the symbol list as they have no // use for the debugger and they are causing a lot of trouble. // Filtering can't be restricted to Android because this special object file don't contain the // note section specifying the environment to Android but the custom extension and file name // makes it highly unlikely that this will collide with anything else. - bool skip_oatdata_oatexec = m_file.GetFilename() == ConstString("system@framework@boot.oat"); + bool skip_oatdata_oatexec = m_file.GetFileNameExtension() == ConstString("oat"); ArchSpec arch; GetArchitecture(arch); |