diff options
author | Pavel Labath <pavel@labath.sk> | 2019-01-24 04:17:59 +0000 |
---|---|---|
committer | Pavel Labath <pavel@labath.sk> | 2019-01-24 04:17:59 +0000 |
commit | 5b18ddb6d1b64c5d9b9d6f8b70470925300b3973 (patch) | |
tree | c4574f638698b0b7df475c3c144feeaed044fa51 /lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp | |
parent | 0bd60172282e56d4cf751c205e890bfa1128ddfc (diff) | |
download | bcm5719-llvm-5b18ddb6d1b64c5d9b9d6f8b70470925300b3973.tar.gz bcm5719-llvm-5b18ddb6d1b64c5d9b9d6f8b70470925300b3973.zip |
BreakpadRecords: Address post-commit feedback
Summary:
This addresses the issues raised in D56844. It removes the accessors from the
breakpad record structures by making the fields public. Also, I refactor the
UUID parsing code to remove hard-coded constants.
Reviewers: lemo
Subscribers: clayborg, lldb-commits
Differential Revision: https://reviews.llvm.org/D57037
llvm-svn: 352021
Diffstat (limited to 'lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp')
-rw-r--r-- | lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp b/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp index c7b5a9943a5..8825c83f747 100644 --- a/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp +++ b/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp @@ -32,13 +32,13 @@ llvm::Optional<Header> Header::parse(llvm::StringRef text) { return llvm::None; llvm::Triple triple; - triple.setArch(Module->getArch()); - triple.setOS(Module->getOS()); + triple.setArch(Module->Arch); + triple.setOS(Module->OS); std::tie(line, text) = text.split('\n'); auto Info = InfoRecord::parse(line); - UUID uuid = Info && Info->getID() ? Info->getID() : Module->getID(); + UUID uuid = Info && Info->ID ? Info->ID : Module->ID; return Header{ArchSpec(triple), std::move(uuid)}; } |