diff options
author | Pavel Labath <labath@google.com> | 2018-05-31 09:46:26 +0000 |
---|---|---|
committer | Pavel Labath <labath@google.com> | 2018-05-31 09:46:26 +0000 |
commit | 34cda14b09e0e55f59ce374265207d9af04d27be (patch) | |
tree | 8048944a9b23fa6a48ccfd966b08b2cd467c0bca /lldb/source/Plugins/LanguageRuntime/RenderScript | |
parent | af3226752b4de38df6b486f5e8949152d1c1daed (diff) | |
download | bcm5719-llvm-34cda14b09e0e55f59ce374265207d9af04d27be.tar.gz bcm5719-llvm-34cda14b09e0e55f59ce374265207d9af04d27be.zip |
Remove append parameter to FindGlobalVariables
Summary:
As discussed in https://bugs.llvm.org/show_bug.cgi?id=37317,
FindGlobalVariables does not properly handle the case where
append=false. As this doesn't seem to be used in the tree, this patch
removes the parameter entirely.
Reviewers: clayborg, jingham, labath
Reviewed By: clayborg
Subscribers: aprantl, lldb-commits, kubamracek, JDevlieghere
Differential Revision: https://reviews.llvm.org/D46885
Patch by Tom Tromey <ttromey@mozilla.com>.
llvm-svn: 333639
Diffstat (limited to 'lldb/source/Plugins/LanguageRuntime/RenderScript')
-rw-r--r-- | lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp b/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp index 6cb665c8cbc..62e08830b35 100644 --- a/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp +++ b/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp @@ -2328,7 +2328,7 @@ void RenderScriptRuntime::FindStructTypeName(Element &elem, VariableList var_list; for (auto module_sp : m_rsmodules) module_sp->m_module->FindGlobalVariables( - RegularExpression(llvm::StringRef(".")), true, UINT32_MAX, var_list); + RegularExpression(llvm::StringRef(".")), UINT32_MAX, var_list); // Iterate over all the global variables looking for one with a matching type // to the Element. We make the assumption a match exists since there needs to @@ -4065,7 +4065,7 @@ void RSModuleDescriptor::Dump(Stream &strm) const { void RSGlobalDescriptor::Dump(Stream &strm) const { strm.Indent(m_name.AsCString()); VariableList var_list; - m_module->m_module->FindGlobalVariables(m_name, nullptr, true, 1U, var_list); + m_module->m_module->FindGlobalVariables(m_name, nullptr, 1U, var_list); if (var_list.GetSize() == 1) { auto var = var_list.GetVariableAtIndex(0); auto type = var->GetType(); |