diff options
author | Enrico Granata <egranata@apple.com> | 2016-05-05 21:10:28 +0000 |
---|---|---|
committer | Enrico Granata <egranata@apple.com> | 2016-05-05 21:10:28 +0000 |
commit | 5f57b6ee0fcd7a26631f4f185b6e848e34fd551d (patch) | |
tree | 5099f9149af6f98e19996994fa7cf661b197aa28 /lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h | |
parent | 5239779465ebbfe9306b31a0732803e37f32f5a8 (diff) | |
download | bcm5719-llvm-5f57b6ee0fcd7a26631f4f185b6e848e34fd551d.tar.gz bcm5719-llvm-5f57b6ee0fcd7a26631f4f185b6e848e34fd551d.zip |
Revert r268591
"Allow LanguageRuntimes to return an error if they fail in the course of dynamic type discovery
This is not meant to report that a value doesn't have a dynamic type - it is only meant as a mechanism to propagate actual type discovery issues (e.g. malformed type metadata for languages that have such a notion)
This information is used by ValueObjectDynamic to set its own m_error, which is a fairly sharp and heavyweight tool to begin with
For the time being, this is an architectural improvement but a practical no-op as no existing runtimes are actually setting errors"
I need to think about what I want to do in this space more carefully - this attempt might be too heavy of a hammer for the nail I am trying to fix, and I don't want to leave it in while I ponder
llvm-svn: 268686
Diffstat (limited to 'lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h')
-rw-r--r-- | lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h index 46001552c8a..342824e79b1 100644 --- a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h +++ b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h @@ -63,8 +63,7 @@ public: lldb::DynamicValueType use_dynamic, TypeAndOrName &class_type_or_name, Address &address, - Value::ValueType &value_type, - Error &error) override; + Value::ValueType &value_type) override; TypeAndOrName FixUpDynamicType (const TypeAndOrName& type_and_or_name, |