diff options
author | Raphael Isemann <teemperor@gmail.com> | 2018-08-14 17:12:54 +0000 |
---|---|---|
committer | Raphael Isemann <teemperor@gmail.com> | 2018-08-14 17:12:54 +0000 |
commit | 2d437f6b026c4f8ccb6e1daac412dd788e76b25a (patch) | |
tree | 5f4767bffbfaa0c8f26615160b88807f8a214327 /lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.h | |
parent | 148c44547567bc2410e8adf3d31e7eefa62f7051 (diff) | |
download | bcm5719-llvm-2d437f6b026c4f8ccb6e1daac412dd788e76b25a.tar.gz bcm5719-llvm-2d437f6b026c4f8ccb6e1daac412dd788e76b25a.zip |
Remove manual byte counting from Highlighter code.
Summary:
This removes the manual byte counting mechanism from the syntax highlighting
code. This is no longer necessary as the Stream class now has built-in support for
automatically counting the bytes that were written to it so far.
The advantage of automatic byte counting via Stream is that it is less error-prone
than the manual version and we need to write less boilerplate code.
Reviewers: labath
Reviewed By: labath
Subscribers: labath, lldb-commits
Differential Revision: https://reviews.llvm.org/D50676
llvm-svn: 339695
Diffstat (limited to 'lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.h')
-rw-r--r-- | lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.h b/lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.h index 4eb239b291b..78971932054 100644 --- a/lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.h +++ b/lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.h @@ -28,9 +28,8 @@ public: ClangHighlighter(); llvm::StringRef GetName() const override { return "clang"; } - std::size_t Highlight(const HighlightStyle &options, llvm::StringRef line, - llvm::StringRef previous_lines, - Stream &s) const override; + void Highlight(const HighlightStyle &options, llvm::StringRef line, + llvm::StringRef previous_lines, Stream &s) const override; /// Returns true if the given string represents a keywords in any Clang /// supported language. |