diff options
| author | Shoaib Meenai <smeenai@fb.com> | 2016-09-28 22:28:51 +0000 |
|---|---|---|
| committer | Shoaib Meenai <smeenai@fb.com> | 2016-09-28 22:28:51 +0000 |
| commit | 3888eb66b004c0d4701330c8097566a734c4aec1 (patch) | |
| tree | 07e2c4c7bc02b70d8c0a0e82eef521c8af3c07c1 /lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp | |
| parent | 40cbc27ff398b425c3dde1270cadd39d7ef9c5bf (diff) | |
| download | bcm5719-llvm-3888eb66b004c0d4701330c8097566a734c4aec1.tar.gz bcm5719-llvm-3888eb66b004c0d4701330c8097566a734c4aec1.zip | |
[libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows
Replace a stale reference to cxx_EXPORTS with _LIBCPP_BUILDING_LIBRARY,
and clarify why the operator new and delete family of functions are
marked dllexport when building but *not* dllimport when including the
header externally.
The new code is identical to the intent of the old code (and would be
functionally equivalent were cxx_EXPORTS still defined when building
libc++). The overall behavior is not ideal, since Microsoft's operator
new and delete functions will get called instead of libc++'s, but I
think consistently calling msvcrt's functions is better than either
calling msvcrt's or libc++'s functions depending on header inclusion.
Differential Revision: https://reviews.llvm.org/D25042
llvm-svn: 282644
Diffstat (limited to 'lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp')
0 files changed, 0 insertions, 0 deletions

