Refactoring. Abstracted the set flags operation into its own helper method

WriteFlags() and renamed WriteCoreRegisterWithFlags() to WriteCoreRegOptionalFlags().
Modified the call sites to use the helper methods.

llvm-svn: 125788

1 files changed, 17 insertions, 8 deletions

diff --git a/lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.h b/lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.h
index 013a84560a2..723aa1cc462 100644
--- a/lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.h
+++ b/lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.h
@@ -194,14 +194,23 @@ public:
 
     // See A8.6.96 MOV (immediate) Operation.
     // Default arguments are specified for carry and overflow parameters, which means
-    // not to update the respective flags if setflags is true.
-    bool
-    WriteCoreRegisterWithFlags (Context &context,
-                                const uint32_t result,
-                                const uint32_t Rd,
-                                bool setflags,
-                                const uint32_t carry = ~0u,
-                                const uint32_t overflow = ~0u);
+    // not to update the respective flags even if setflags is true.
+    bool
+    WriteCoreRegOptionalFlags (Context &context,
+                               const uint32_t result,
+                               const uint32_t Rd,
+                               bool setflags,
+                               const uint32_t carry = ~0u,
+                               const uint32_t overflow = ~0u);
+
+    // See A8.6.35 CMP (immediate) Operation.
+    // Default arguments are specified for carry and overflow parameters, which means
+    // not to update the respective flags.
+    bool
+    WriteFlags (Context &context,
+                const uint32_t result,
+                const uint32_t carry = ~0u,
+                const uint32_t overflow = ~0u);
 
     inline uint64_t
     MemARead (EmulateInstruction::Context &context,