diff options
| author | Jason Molenda <jmolenda@apple.com> | 2019-01-25 03:01:48 +0000 |
|---|---|---|
| committer | Jason Molenda <jmolenda@apple.com> | 2019-01-25 03:01:48 +0000 |
| commit | 9073eb4f25e1cb6ec9cbe923daa75f010f6115f7 (patch) | |
| tree | 8f4a8b55f3d6493a3650491aad7dc5695dc9e351 /lldb/source/Plugins/DynamicLoader | |
| parent | 1b1e685f1096c95441edbfff9c4714321f84d9a7 (diff) | |
| download | bcm5719-llvm-9073eb4f25e1cb6ec9cbe923daa75f010f6115f7.tar.gz bcm5719-llvm-9073eb4f25e1cb6ec9cbe923daa75f010f6115f7.zip | |
Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress
when the binary loaded in memory has a section that we cannot find
in the on-disk version. I added this warning out of an overabundance
of caution originally, but I've never seen an instance of it being
hit in the past few years, and there are some changes for the shared
cache on darwin systems where a segment is added when the shared
cache is constructed so we're now hitting this warning. I've decided
to remove it altogether.
<rdar://problem/46889346>
llvm-svn: 352158
Diffstat (limited to 'lldb/source/Plugins/DynamicLoader')
| -rw-r--r-- | lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp index 9104b1623af..6f7e93d170f 100644 --- a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp +++ b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp @@ -255,15 +255,7 @@ bool DynamicLoaderDarwin::UpdateImageLoadAddress(Module *module, changed = m_process->GetTarget().SetSectionLoadAddress( section_sp, new_section_load_addr, warn_multiple); - } else { - Host::SystemLog( - Host::eSystemLogWarning, - "warning: unable to find and load segment named '%s' at " - "0x%" PRIx64 " in '%s' in macosx dynamic loader plug-in.\n", - info.segments[i].name.AsCString("<invalid>"), - (uint64_t)new_section_load_addr, - image_object_file->GetFileSpec().GetPath().c_str()); - } + } } } |

