diff options
| author | Greg Clayton <gclayton@apple.com> | 2012-03-07 21:03:09 +0000 |
|---|---|---|
| committer | Greg Clayton <gclayton@apple.com> | 2012-03-07 21:03:09 +0000 |
| commit | e761213428bb1ad8a8835ac4bf52233ae2121f3c (patch) | |
| tree | 746b13d7e3e796f69acc994362c23f732a380542 /lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp | |
| parent | 377f1f2d399171983cc26c13e81bad1699025dde (diff) | |
| download | bcm5719-llvm-e761213428bb1ad8a8835ac4bf52233ae2121f3c.tar.gz bcm5719-llvm-e761213428bb1ad8a8835ac4bf52233ae2121f3c.zip | |
<rdar://problem/10997402>
This fix really needed to happen as a previous fix I had submitted for
calculating symbol sizes made many symbols appear to have zero size since
the function that was calculating the symbol size was calling another function
that would cause the calculation to happen again. This resulted in some symbols
having zero size when they shouldn't. This could then cause infinite stack
traces and many other side affects.
llvm-svn: 152244
Diffstat (limited to 'lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp')
| -rw-r--r-- | lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp index 31e3e5d1b62..3406a898850 100644 --- a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp +++ b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp @@ -342,7 +342,7 @@ DynamicLoaderMacOSXDYLD::ReadDYLDInfoFromMemoryAndSetNotificationCallback(lldb:: static ConstString g_dyld_all_image_infos ("dyld_all_image_infos"); const Symbol *symbol = dyld_module_sp->FindFirstSymbolWithNameAndType (g_dyld_all_image_infos, eSymbolTypeData); if (symbol) - m_dyld_all_image_infos_addr = symbol->GetValue().GetLoadAddress(&m_process->GetTarget()); + m_dyld_all_image_infos_addr = symbol->GetAddress().GetLoadAddress(&m_process->GetTarget()); } // Update all image infos @@ -1333,11 +1333,7 @@ DynamicLoaderMacOSXDYLD::AlwaysRelyOnEHUnwindInfo (SymbolContext &sym_ctx) ModuleSP module_sp; if (sym_ctx.symbol) { - AddressRange *ar = sym_ctx.symbol->GetAddressRangePtr(); - if (ar) - { - module_sp = ar->GetBaseAddress().GetModule(); - } + module_sp = sym_ctx.symbol->GetAddress().GetModule(); } if (module_sp.get() == NULL && sym_ctx.function) { |

