diff options
author | Tatyana Krasnukha <tatyana@synopsys.com> | 2018-06-26 13:06:54 +0000 |
---|---|---|
committer | Tatyana Krasnukha <tatyana@synopsys.com> | 2018-06-26 13:06:54 +0000 |
commit | 04803b3ef2cf327166a65c7f8a7804a2b93e6d2f (patch) | |
tree | 922ba904efe9087a7614414e9b93de7abd09dd26 /lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp | |
parent | bbadbe016f3f1d72aa7adff1a8863c4128fc39ca (diff) | |
download | bcm5719-llvm-04803b3ef2cf327166a65c7f8a7804a2b93e6d2f.tar.gz bcm5719-llvm-04803b3ef2cf327166a65c7f8a7804a2b93e6d2f.zip |
Change AddressClass type from 'enum' to 'enum class'.
If we have a function with signature f(addr_t, AddressClass), it is easy to muddle up the order of arguments without any warnings from compiler. 'enum class' prevents passing integer in place of AddressClass and vice versa.
llvm-svn: 335599
Diffstat (limited to 'lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp')
-rw-r--r-- | lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp b/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp index e6f6a41e8ab..9b381dd3b96 100644 --- a/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp +++ b/lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp @@ -173,7 +173,7 @@ public: if (disasm_sp->m_alternate_disasm_up) { const AddressClass address_class = GetAddressClass(); - if (address_class == eAddressClassCodeAlternateISA) { + if (address_class == AddressClass::eCodeAlternateISA) { is_alternate_isa = true; return disasm_sp->m_alternate_disasm_up.get(); } @@ -300,7 +300,7 @@ public: if (disasm_sp) { DisassemblerLLVMC::MCDisasmInstance *mc_disasm_ptr; - if (address_class == eAddressClassCodeAlternateISA) + if (address_class == AddressClass::eCodeAlternateISA) mc_disasm_ptr = disasm_sp->m_alternate_disasm_up.get(); else mc_disasm_ptr = disasm_sp->m_disasm_up.get(); @@ -1257,7 +1257,7 @@ size_t DisassemblerLLVMC::DecodeInstructions(const Address &base_addr, while (data_cursor < data_byte_size && instructions_parsed < num_instructions) { - AddressClass address_class = eAddressClassCode; + AddressClass address_class = AddressClass::eCode; if (m_alternate_disasm_up) address_class = inst_addr.GetAddressClass(); |