Reimplemented the code that backed the "settings" in lldb. There were many issues with the previous implementation:

- no setting auto completion
- very manual and error prone way of getting/setting variables
- tons of code duplication
- useless instance names for processes, threads

Now settings can easily be defined like option values. The new settings makes use of the "OptionValue" classes so we can re-use the option value code that we use to set settings in command options. No more instances, just "does the right thing".

llvm-svn: 162366

1 files changed, 77 insertions, 0 deletions

diff --git a/lldb/source/Interpreter/OptionValueString.cpp b/lldb/source/Interpreter/OptionValueString.cpp
new file mode 100644
index 00000000000..35ab8c8f7ce
--- /dev/null
+++ b/lldb/source/Interpreter/OptionValueString.cpp
@@ -0,0 +1,77 @@
+//===-- OptionValueString.cpp ------------------------------------*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#include "lldb/Interpreter/OptionValueString.h"
+
+// C Includes
+// C++ Includes
+// Other libraries and framework includes
+// Project includes
+#include "lldb/Core/Stream.h"
+
+using namespace lldb;
+using namespace lldb_private;
+
+void
+OptionValueString::DumpValue (const ExecutionContext *exe_ctx, Stream &strm, uint32_t dump_mask)
+{
+    if (dump_mask & eDumpOptionType)
+        strm.Printf ("(%s)", GetTypeAsCString ());
+    if (dump_mask & eDumpOptionValue)
+    {
+        if (dump_mask & eDumpOptionType)
+            strm.PutCString (" = ");
+        if (!m_current_value.empty() || m_value_was_set)
+        {
+            if (dump_mask & eDumpOptionRaw)
+                strm.Printf ("%s", m_current_value.c_str());
+            else
+                strm.Printf ("\"%s\"", m_current_value.c_str());
+        }
+    }
+}
+
+Error
+OptionValueString::SetValueFromCString (const char *value_cstr,
+                                        VarSetOperationType op)
+{
+    Error error;
+    switch (op)
+    {
+    case eVarSetOperationInvalid:
+    case eVarSetOperationInsertBefore:
+    case eVarSetOperationInsertAfter:
+    case eVarSetOperationRemove:
+        error = OptionValue::SetValueFromCString (value_cstr, op);
+        break;
+
+    case eVarSetOperationAppend:
+        if (value_cstr && value_cstr[0])
+            m_current_value += value_cstr;
+        break;
+
+    case eVarSetOperationClear:
+        Clear ();
+        break;
+
+    case eVarSetOperationReplace:
+    case eVarSetOperationAssign:
+        m_value_was_set = true;
+        SetCurrentValue (value_cstr);
+        break;
+    }
+    return error;
+}
+
+
+lldb::OptionValueSP
+OptionValueString::DeepCopy () const
+{
+    return OptionValueSP(new OptionValueString(*this));
+}