Fixed an issue where if the operating system python plug-in is changed at runtime, it wouldn't cause the process to reload the new operating system plug-in, now it does.

This is currently controlled by a setting:

(lldb) settings set target.process.python-os-plugin-path <path>

Or clearing it with:

(lldb) settings clear target.process.python-os-plugin-path 

The process will now reload the OperatingSystem plug-in.

This was implemented by:
- adding the ability to set a notify callback for when an option value is changed
- added the ability for the process plug-in to load the operating system plug-in on the fly
- fixed bugs in the Process::GetStatus() so all threads are displayed if their thread IDs are larger than 32 bits
- adding a callback in ProcessProperties to tell when the "python-os-plugin-path" is changed by the user
- fixing a crasher in ProcessMachCore that happens when updating the thread list when the OS plugin is reloaded

llvm-svn: 225831

1 files changed, 20 insertions, 17 deletions

diff --git a/lldb/source/Interpreter/OptionValueString.cpp b/lldb/source/Interpreter/OptionValueString.cpp
index df047bd9899..a1b80d8fc4f 100644
--- a/lldb/source/Interpreter/OptionValueString.cpp
+++ b/lldb/source/Interpreter/OptionValueString.cpp
@@ -94,30 +94,32 @@ OptionValueString::SetValueFromCString (const char *value_cstr,
 
     case eVarSetOperationAppend:
         {
-        std::string new_value(m_current_value);
-        if (value_cstr && value_cstr[0])
-        {
-            if (m_options.Test (eOptionEncodeCharacterEscapeSequences))
+            std::string new_value(m_current_value);
+            if (value_cstr && value_cstr[0])
             {
-                std::string str;
-                Args::EncodeEscapeSequences (value_cstr, str);
-                new_value.append(str);
+                if (m_options.Test (eOptionEncodeCharacterEscapeSequences))
+                {
+                    std::string str;
+                    Args::EncodeEscapeSequences (value_cstr, str);
+                    new_value.append(str);
+                }
+                else
+                    new_value.append(value_cstr);
             }
-            else
-                new_value.append(value_cstr);
-        }
-        if (m_validator)
-        {
-            error = m_validator(new_value.c_str(),m_validator_baton);
-            if (error.Fail())
-                return error;
-        }
-        m_current_value.assign(new_value);
+            if (m_validator)
+            {
+                error = m_validator(new_value.c_str(),m_validator_baton);
+                if (error.Fail())
+                    return error;
+            }
+            m_current_value.assign(new_value);
+            NotifyValueChanged();
         }
         break;
 
     case eVarSetOperationClear:
         Clear ();
+        NotifyValueChanged();
         break;
 
     case eVarSetOperationReplace:
@@ -137,6 +139,7 @@ OptionValueString::SetValueFromCString (const char *value_cstr,
         {
             SetCurrentValue (value_cstr);
         }
+        NotifyValueChanged();
         break;
     }
     return error;