summaryrefslogtreecommitdiffstats
path: root/lldb/source/Interpreter/CommandObjectRegexCommand.cpp
diff options
context:
space:
mode:
authorJan Kratochvil <jan.kratochvil@redhat.com>2019-08-20 09:24:20 +0000
committerJan Kratochvil <jan.kratochvil@redhat.com>2019-08-20 09:24:20 +0000
commitf9d90bc5f690de43cbfd8bd15f6f3d3e01471615 (patch)
tree3c62c4c7ea05d724f34236e40c08bf1526f0d5ac /lldb/source/Interpreter/CommandObjectRegexCommand.cpp
parent12d83b427015083f40964c706a5b9e428d9d88df (diff)
downloadbcm5719-llvm-f9d90bc5f690de43cbfd8bd15f6f3d3e01471615.tar.gz
bcm5719-llvm-f9d90bc5f690de43cbfd8bd15f6f3d3e01471615.zip
[lldb] D66174 `RegularExpression` cleanup
I find as a good cleanup to drop the Compile method. As I do not find TIMTOWTDI as an advantage and there is already constructor parameter to compile the regex. Differential Revision: https://reviews.llvm.org/D66392 llvm-svn: 369352
Diffstat (limited to 'lldb/source/Interpreter/CommandObjectRegexCommand.cpp')
-rw-r--r--lldb/source/Interpreter/CommandObjectRegexCommand.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/lldb/source/Interpreter/CommandObjectRegexCommand.cpp b/lldb/source/Interpreter/CommandObjectRegexCommand.cpp
index 16e6feb957c..94e52a36fb3 100644
--- a/lldb/source/Interpreter/CommandObjectRegexCommand.cpp
+++ b/lldb/source/Interpreter/CommandObjectRegexCommand.cpp
@@ -73,8 +73,9 @@ bool CommandObjectRegexCommand::AddRegexCommand(const char *re_cstr,
const char *command_cstr) {
m_entries.resize(m_entries.size() + 1);
// Only add the regular expression if it compiles
- if (m_entries.back().regex.Compile(
- llvm::StringRef::withNullAsEmpty(re_cstr))) {
+ m_entries.back().regex =
+ RegularExpression(llvm::StringRef::withNullAsEmpty(re_cstr));
+ if (m_entries.back().regex.IsValid()) {
m_entries.back().command.assign(command_cstr);
return true;
}
OpenPOWER on IntegriCloud