diff options
| author | Pavel Labath <labath@google.com> | 2016-02-01 13:29:41 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2016-02-01 13:29:41 +0000 |
| commit | 061140c680d2f0685b160e06216304ffe09f1d44 (patch) | |
| tree | 9cb31591aa2b03d926c3b645c284022fa37b723e /lldb/source/Initialization | |
| parent | 6277b185d4059358056d35af093bc195206a67b5 (diff) | |
| download | bcm5719-llvm-061140c680d2f0685b160e06216304ffe09f1d44.tar.gz bcm5719-llvm-061140c680d2f0685b160e06216304ffe09f1d44.zip | |
Remove Timer::Initialize routine
Summary:
I've run into an issue when running unit tests, where the underlying problem turned out to be
that we were creating Timer objects (through several layers of indirection) without calling
Timer::Initialize. Since Timer's thread-local storage was not properly initialized, we were
overwriting gtest's own thread-local storage, causing test failures.
Instead of requiring that every test calls Timer::Initialize(), I remove the function altogether:
The thread-local storage can be initialized on-demand, and the g_file variable initialized to
stdout and never changed, so I have simply removed it.
Reviewers: clayborg, zturner, tberghammer
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D16722
llvm-svn: 259356
Diffstat (limited to 'lldb/source/Initialization')
| -rw-r--r-- | lldb/source/Initialization/SystemInitializerCommon.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lldb/source/Initialization/SystemInitializerCommon.cpp b/lldb/source/Initialization/SystemInitializerCommon.cpp index 6cbc0b707df..a5e3c116e72 100644 --- a/lldb/source/Initialization/SystemInitializerCommon.cpp +++ b/lldb/source/Initialization/SystemInitializerCommon.cpp @@ -97,7 +97,6 @@ SystemInitializerCommon::Initialize() Log::Initialize(); HostInfo::Initialize(); - Timer::Initialize(); Timer scoped_timer(__PRETTY_FUNCTION__, __PRETTY_FUNCTION__); llvm::install_fatal_error_handler(fatal_error_handler, 0); |

