diff options
| author | Pavel Labath <labath@google.com> | 2017-07-18 13:14:01 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2017-07-18 13:14:01 +0000 |
| commit | b6dbe9a99c35b5dd101d45f220f95f6e9e85d15e (patch) | |
| tree | a9522e28f97a4f14f49be49f0249141c23079fca /lldb/source/Host/common | |
| parent | 30fc523984dec81232167e07d8fc25c92e8562f7 (diff) | |
| download | bcm5719-llvm-b6dbe9a99c35b5dd101d45f220f95f6e9e85d15e.tar.gz bcm5719-llvm-b6dbe9a99c35b5dd101d45f220f95f6e9e85d15e.zip | |
Clean up lldb-types.h
Summary:
It defined a couple of types (condition_t) which we don't use anymore,
as we have c++11 goodies now. I remove these definitions.
Also it unnecessarily included a couple of headers which weren't
necessary for it's operation. I remove these, and place the includes in
the relevant files (usually .cpp, usually in Host code) which use them.
This allows us to reduce namespace pollution in most of the lldb files
which don't need the OS-specific definitions.
Reviewers: zturner, jingham
Subscribers: ki.stfu, lldb-commits
Differential Revision: https://reviews.llvm.org/D35113
llvm-svn: 308304
Diffstat (limited to 'lldb/source/Host/common')
| -rw-r--r-- | lldb/source/Host/common/File.cpp | 1 | ||||
| -rw-r--r-- | lldb/source/Host/common/Socket.cpp | 1 | ||||
| -rw-r--r-- | lldb/source/Host/common/TCPSocket.cpp | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/lldb/source/Host/common/File.cpp b/lldb/source/Host/common/File.cpp index 90a4462c6ca..6ee4e894756 100644 --- a/lldb/source/Host/common/File.cpp +++ b/lldb/source/Host/common/File.cpp @@ -21,6 +21,7 @@ #include <sys/ioctl.h> #include <sys/stat.h> #include <termios.h> +#include <unistd.h> #endif #include "llvm/Support/ConvertUTF.h" diff --git a/lldb/source/Host/common/Socket.cpp b/lldb/source/Host/common/Socket.cpp index 0df9dc02c70..5490e9b30bd 100644 --- a/lldb/source/Host/common/Socket.cpp +++ b/lldb/source/Host/common/Socket.cpp @@ -29,6 +29,7 @@ #include <netinet/tcp.h> #include <sys/socket.h> #include <sys/un.h> +#include <unistd.h> #endif #ifdef __linux__ diff --git a/lldb/source/Host/common/TCPSocket.cpp b/lldb/source/Host/common/TCPSocket.cpp index c013334ce23..a7af93f10a7 100644 --- a/lldb/source/Host/common/TCPSocket.cpp +++ b/lldb/source/Host/common/TCPSocket.cpp @@ -34,6 +34,7 @@ #define CLOSE_SOCKET closesocket typedef const char *set_socket_option_arg_type; #else +#include <unistd.h> #define CLOSE_SOCKET ::close typedef const void *set_socket_option_arg_type; #endif |
