diff options
| author | Aleksandr Urakov <aleksandr.urakov@jetbrains.com> | 2019-02-01 10:01:18 +0000 |
|---|---|---|
| committer | Aleksandr Urakov <aleksandr.urakov@jetbrains.com> | 2019-02-01 10:01:18 +0000 |
| commit | 758657e56550c0681260bb61b0a2bddb4a5c2e6d (patch) | |
| tree | cd529a2f27ed73e5871fc04afa541f0a97959ade /lldb/source/Expression | |
| parent | bac11518cd44f85cea38e5be116388cd254de9eb (diff) | |
| download | bcm5719-llvm-758657e56550c0681260bb61b0a2bddb4a5c2e6d.tar.gz bcm5719-llvm-758657e56550c0681260bb61b0a2bddb4a5c2e6d.zip | |
[PDB] Fix location retrieval for function local variables and arguments that are
stored relative to VFRAME
Summary:
This patch makes LLDB able to retrieve proper values for function arguments and
local variables stored in PDB relative to VFRAME register.
Patch contains retrieval of corresponding FPO table entries from PDB and a
generic translator from FPO programs to DWARF expressions to get correct VFRAME
value.
Patch also improves variables-locations.test and makes this test passable on
x86.
Patch By: leonid.mashinsky
Reviewers: zturner, asmith, stella.stamenova, aleksandr.urakov
Reviewed By: zturner
Subscribers: arphaman, labath, mgorny, aprantl, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D55122
llvm-svn: 352845
Diffstat (limited to 'lldb/source/Expression')
| -rw-r--r-- | lldb/source/Expression/DWARFExpression.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/source/Expression/DWARFExpression.cpp b/lldb/source/Expression/DWARFExpression.cpp index 4d002a4f452..8c7db6f78f2 100644 --- a/lldb/source/Expression/DWARFExpression.cpp +++ b/lldb/source/Expression/DWARFExpression.cpp @@ -3203,7 +3203,7 @@ static bool print_dwarf_exp_op(Stream &s, const DataExtractor &data, break; default: s.Printf("UNKNOWN ONE-OPERAND OPCODE, #%u", opcode); - return true; + return false; } switch (size) { @@ -3249,7 +3249,7 @@ static bool print_dwarf_exp_op(Stream &s, const DataExtractor &data, break; } - return false; + return true; } bool DWARFExpression::PrintDWARFExpression(Stream &s, const DataExtractor &data, |

