Made many ConstString functions inlined in the header file.

Changed all of our synthesized "___clang" functions, types and variables
that get used in expressions over to have a prefix of "$_lldb". Now when we
do name lookups we can easily switch off of the first '$' character to know
if we should look through only our internal (when first char is '$') stuff,
or when we should look through program variables, functions and types.

Converted all of the clang expression code over to using "const ConstString&" 
values for names instead of "const char *" since there were many places that
were converting the "const char *" names into ConstString names and them
throwing them away. We now avoid making a lot of ConstString conversions and
benefit from the quick comparisons in a few extra spots.

Converted a lot of code from LLVM coding conventions into LLDB coding 
conventions.

llvm-svn: 116634

1 files changed, 2 insertions, 2 deletions

diff --git a/lldb/source/Expression/ASTResultSynthesizer.cpp b/lldb/source/Expression/ASTResultSynthesizer.cpp
index 0cdcf2a110d..8fe605f3e01 100644
--- a/lldb/source/Expression/ASTResultSynthesizer.cpp
+++ b/lldb/source/Expression/ASTResultSynthesizer.cpp
@@ -70,7 +70,7 @@ ASTResultSynthesizer::TransformTopLevelDecl(Decl* D)
     
     if (m_ast_context &&
         function_decl &&
-        !function_decl->getNameInfo().getAsString().compare("___clang_expr"))
+        !function_decl->getNameInfo().getAsString().compare("$__lldb_expr"))
     {
         SynthesizeResult(function_decl);
     }
@@ -164,7 +164,7 @@ ASTResultSynthesizer::SynthesizeResult (FunctionDecl *FunDecl)
         log->Printf("Last statement's type: %s", s.c_str());
     }
     
-    IdentifierInfo &result_id = Ctx.Idents.get("___clang_expr_result");
+    IdentifierInfo &result_id = Ctx.Idents.get("$__lldb_expr_result");
         
     clang::VarDecl *result_decl = VarDecl::Create(Ctx, 
                                                   function_decl,