Don't allow direct access to StreamString's internal buffer.

This is a large API change that removes the two functions from
StreamString that return a std::string& and a const std::string&,
and instead provide one function which returns a StringRef.

Direct access to the underlying buffer violates the concept of
a "stream" which is intended to provide forward only access,
and makes porting to llvm::raw_ostream more difficult in the
future.

Differential Revision: https://reviews.llvm.org/D26698

llvm-svn: 287152

1 files changed, 6 insertions, 7 deletions

diff --git a/lldb/source/DataFormatters/ValueObjectPrinter.cpp b/lldb/source/DataFormatters/ValueObjectPrinter.cpp
index 9e66d8dfb2a..d6efe78e49a 100644
--- a/lldb/source/DataFormatters/ValueObjectPrinter.cpp
+++ b/lldb/source/DataFormatters/ValueObjectPrinter.cpp
@@ -1,5 +1,4 @@
-//===-- ValueObjectPrinter.cpp -------------------------------------*- C++
-//-*-===//
+//===-- ValueObjectPrinter.cpp -----------------------------------*- C++-*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
@@ -302,22 +301,22 @@ void ValueObjectPrinter::PrintDecl() {
   }
 
   if (m_options.m_decl_printing_helper) {
-    ConstString type_name_cstr(typeName.GetData());
-    ConstString var_name_cstr(varName.GetData());
+    ConstString type_name_cstr(typeName.GetString());
+    ConstString var_name_cstr(varName.GetString());
 
     StreamString dest_stream;
     if (m_options.m_decl_printing_helper(type_name_cstr, var_name_cstr,
                                          m_options, dest_stream)) {
       decl_printed = true;
-      m_stream->Printf("%s", dest_stream.GetData());
+      m_stream->PutCString(dest_stream.GetString());
     }
   }
 
   // if the helper failed, or there is none, do a default thing
   if (!decl_printed) {
-    if (typeName.GetSize())
+    if (!typeName.Empty())
       m_stream->Printf("(%s) ", typeName.GetData());
-    if (varName.GetSize())
+    if (!varName.Empty())
       m_stream->Printf("%s =", varName.GetData());
     else if (!m_options.m_hide_name)
       m_stream->Printf(" =");