diff options
author | Zachary Turner <zturner@google.com> | 2019-01-14 22:40:41 +0000 |
---|---|---|
committer | Zachary Turner <zturner@google.com> | 2019-01-14 22:40:41 +0000 |
commit | ffc1b8fd7653cdc61440bc0be5d3735146dd5015 (patch) | |
tree | 9aecd781d8a7ec2e1813196c169f545d39e7b40e /lldb/source/Core/Module.cpp | |
parent | 786558882cb649051a94e9fd1753fd8699fa6dac (diff) | |
download | bcm5719-llvm-ffc1b8fd7653cdc61440bc0be5d3735146dd5015.tar.gz bcm5719-llvm-ffc1b8fd7653cdc61440bc0be5d3735146dd5015.zip |
[SymbolFile] Rename ParseFunctionBlocks to ParseBlocksRecursive.
This method took a SymbolContext but only actually cared about the
case where the m_function member was set. Furthermore, it was
intended to be implemented to parse blocks recursively despite not
documenting this in its name. So we change the name to indicate
that it should be recursive, while also limiting the function
parameter to be a Function&. This lets the caller know what is
required to use it, as well as letting new implementers know what
kind of inputs they need to be prepared to handle.
llvm-svn: 351131
Diffstat (limited to 'lldb/source/Core/Module.cpp')
-rw-r--r-- | lldb/source/Core/Module.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lldb/source/Core/Module.cpp b/lldb/source/Core/Module.cpp index 6595d134079..3e3a1e0c3de 100644 --- a/lldb/source/Core/Module.cpp +++ b/lldb/source/Core/Module.cpp @@ -373,9 +373,10 @@ void Module::ParseAllDebugSymbols() { symbols->ParseFunctions(*sc.comp_unit); sc.comp_unit->ForeachFunction([&sc, &symbols](const FunctionSP &f) { - sc.function = f.get(); - symbols->ParseFunctionBlocks(sc); + symbols->ParseBlocksRecursive(*f); + // Parse the variables for this function and all its blocks + sc.function = f.get(); symbols->ParseVariablesForContext(sc); return false; }); |