diff options
| author | Pavel Labath <labath@google.com> | 2017-02-05 00:44:54 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2017-02-05 00:44:54 +0000 |
| commit | 3b7e1981b2f66e0677f964a3e9cf30ce2d7d3f84 (patch) | |
| tree | 235951d23167dfb1ee2385c906175011780ba1e7 /lldb/source/Core/Logging.cpp | |
| parent | 978fdb75a4a21d8209b51c08d4bcd16a43e0779d (diff) | |
| download | bcm5719-llvm-3b7e1981b2f66e0677f964a3e9cf30ce2d7d3f84.tar.gz bcm5719-llvm-3b7e1981b2f66e0677f964a3e9cf30ce2d7d3f84.zip | |
Remove LIBLLDB_LOG_VERBOSE category
Summary:
Per discussion in D28616, having two ways two request logging (log
enable lldb XXX verbose && log enable -v lldb XXX) is confusing. This
removes the first option and standardizes all code to use the second
one.
I've added a LLDB_LOGV macro as a shorthand for if(log &&
log->GetVerbose()) and switched most of the affected log statements to
use that (I've only left a couple of cases that were doing complex
computations in an if(log) block).
Reviewers: jingham, zturner
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D29510
llvm-svn: 294113
Diffstat (limited to 'lldb/source/Core/Logging.cpp')
| -rw-r--r-- | lldb/source/Core/Logging.cpp | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/lldb/source/Core/Logging.cpp b/lldb/source/Core/Logging.cpp index 4d63b60eecc..1d42df111a4 100644 --- a/lldb/source/Core/Logging.cpp +++ b/lldb/source/Core/Logging.cpp @@ -44,11 +44,6 @@ uint32_t lldb_private::GetLogMask() { return 0; } -bool lldb_private::IsLogVerbose() { - uint32_t mask = GetLogMask(); - return (mask & LIBLLDB_LOG_VERBOSE); -} - Log *lldb_private::GetLogIfAllCategoriesSet(uint32_t mask) { Log *log(GetLog()); if (log && mask) { @@ -130,8 +125,6 @@ void lldb_private::DisableLog(const char **categories, Stream *feedback_strm) { flag_bits &= ~LIBLLDB_LOG_THREAD; else if (0 == ::strcasecmp(arg, "target")) flag_bits &= ~LIBLLDB_LOG_TARGET; - else if (0 == ::strcasecmp(arg, "verbose")) - flag_bits &= ~LIBLLDB_LOG_VERBOSE; else if (0 == ::strncasecmp(arg, "watch", 5)) flag_bits &= ~LIBLLDB_LOG_WATCHPOINTS; else if (0 == ::strncasecmp(arg, "temp", 4)) @@ -257,8 +250,6 @@ Log *lldb_private::EnableLog(StreamSP &log_stream_sp, uint32_t log_options, flag_bits |= LIBLLDB_LOG_TYPES; else if (0 == ::strncasecmp(arg, "unwind", 6)) flag_bits |= LIBLLDB_LOG_UNWIND; - else if (0 == ::strcasecmp(arg, "verbose")) - flag_bits |= LIBLLDB_LOG_VERBOSE; else if (0 == ::strncasecmp(arg, "watch", 5)) flag_bits |= LIBLLDB_LOG_WATCHPOINTS; else if (0 == ::strcasecmp(arg, "jit")) |
