diff options
| author | Greg Clayton <gclayton@apple.com> | 2012-08-22 17:17:09 +0000 |
|---|---|---|
| committer | Greg Clayton <gclayton@apple.com> | 2012-08-22 17:17:09 +0000 |
| commit | 67cc06366cdb20795d21c31f89624d81e97af799 (patch) | |
| tree | 43edfb98f1f542853282474c9685a5e071d2e1d9 /lldb/source/Core/Disassembler.cpp | |
| parent | 40dd4d9bf396f17b28fe823160f3e103d2943cfb (diff) | |
| download | bcm5719-llvm-67cc06366cdb20795d21c31f89624d81e97af799.tar.gz bcm5719-llvm-67cc06366cdb20795d21c31f89624d81e97af799.zip | |
Reimplemented the code that backed the "settings" in lldb. There were many issues with the previous implementation:
- no setting auto completion
- very manual and error prone way of getting/setting variables
- tons of code duplication
- useless instance names for processes, threads
Now settings can easily be defined like option values. The new settings makes use of the "OptionValue" classes so we can re-use the option value code that we use to set settings in command options. No more instances, just "does the right thing".
llvm-svn: 162366
Diffstat (limited to 'lldb/source/Core/Disassembler.cpp')
| -rw-r--r-- | lldb/source/Core/Disassembler.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/lldb/source/Core/Disassembler.cpp b/lldb/source/Core/Disassembler.cpp index 96828f4a7db..6b6b6eeeddc 100644 --- a/lldb/source/Core/Disassembler.cpp +++ b/lldb/source/Core/Disassembler.cpp @@ -23,7 +23,11 @@ #include "lldb/Core/PluginManager.h" #include "lldb/Core/RegularExpression.h" #include "lldb/Core/Timer.h" -#include "lldb/Interpreter/NamedOptionValue.h" +#include "lldb/Interpreter/OptionValue.h" +#include "lldb/Interpreter/OptionValueArray.h" +#include "lldb/Interpreter/OptionValueDictionary.h" +#include "lldb/Interpreter/OptionValueString.h" +#include "lldb/Interpreter/OptionValueUInt64.h" #include "lldb/Symbol/ClangNamespaceDecl.h" #include "lldb/Symbol/ObjectFile.h" #include "lldb/Target/ExecutionContext.h" |
