diff options
author | Enrico Granata <granata.enrico@gmail.com> | 2011-07-19 18:03:25 +0000 |
---|---|---|
committer | Enrico Granata <granata.enrico@gmail.com> | 2011-07-19 18:03:25 +0000 |
commit | 20edcdbe8a267924e19646374cbead05ec9ea027 (patch) | |
tree | 9fa2db828ee6766299dde760d07431b4602c2423 /lldb/source/Core/DataExtractor.cpp | |
parent | 33824e572253bcb491a7e0d2a09a7f857f259f34 (diff) | |
download | bcm5719-llvm-20edcdbe8a267924e19646374cbead05ec9ea027.tar.gz bcm5719-llvm-20edcdbe8a267924e19646374cbead05ec9ea027.zip |
The implementation of categories is now synchronization safe
Code cleanup:
- The Format Manager implementation is now split between two files: FormatClasses.{h|cpp} where the
actual formatter classes (ValueFormat, SummaryFormat, ...) are implemented and
FormatManager.{h|cpp} where the infrastructure classes (FormatNavigator, FormatManager, ...)
are contained. The wrapper code always remains in Debugger.{h|cpp}
- Several leftover fields, methods and comments from previous design choices have been removed
type category subcommands (enable, disable, delete) now can take a list of category names as input
- for type category enable, saying "enable A B C" is the same as saying
enable C
enable B
enable A
(the ordering is relevant in enabling categories, and it is expected that a user typing
enable A B C wants to look into category A, then into B, then into C and not the other
way round)
- for the other two commands, the order is not really relevant (however, the same inverted ordering
is used for consistency)
llvm-svn: 135494
Diffstat (limited to 'lldb/source/Core/DataExtractor.cpp')
-rw-r--r-- | lldb/source/Core/DataExtractor.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Core/DataExtractor.cpp b/lldb/source/Core/DataExtractor.cpp index e364dfd6097..f8be9a421e0 100644 --- a/lldb/source/Core/DataExtractor.cpp +++ b/lldb/source/Core/DataExtractor.cpp @@ -754,7 +754,7 @@ DataExtractor::GetMaxU64Bitfield (uint32_t *offset_ptr, uint32_t size, uint32_t if (bitfield_bit_offset > 0) uval64 >>= bitfield_bit_offset; uint64_t bitfield_mask = ((1ul << bitfield_bit_size) - 1); - if(!bitfield_mask && bitfield_bit_offset == 0 && bitfield_bit_size == 64) + if (!bitfield_mask && bitfield_bit_offset == 0 && bitfield_bit_size == 64) return uval64; uval64 &= bitfield_mask; } |