summaryrefslogtreecommitdiffstats
path: root/lldb/source/Core/ConnectionFileDescriptor.cpp
diff options
context:
space:
mode:
authorEd Maste <emaste@freebsd.org>2014-06-11 18:10:41 +0000
committerEd Maste <emaste@freebsd.org>2014-06-11 18:10:41 +0000
commita5fd299734555dbf861e8f44b780f0ba41e1cd23 (patch)
treed442237284a45bcb557b70701a860ed13a1ee5ca /lldb/source/Core/ConnectionFileDescriptor.cpp
parent5cc241753232a1c201c8592509fc78d5d7135dfa (diff)
downloadbcm5719-llvm-a5fd299734555dbf861e8f44b780f0ba41e1cd23.tar.gz
bcm5719-llvm-a5fd299734555dbf861e8f44b780f0ba41e1cd23.zip
Restore select limitations comment for non-Apple platforms
llvm-svn: 210682
Diffstat (limited to 'lldb/source/Core/ConnectionFileDescriptor.cpp')
-rw-r--r--lldb/source/Core/ConnectionFileDescriptor.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/lldb/source/Core/ConnectionFileDescriptor.cpp b/lldb/source/Core/ConnectionFileDescriptor.cpp
index 5c5f0ed2f76..acb636809b7 100644
--- a/lldb/source/Core/ConnectionFileDescriptor.cpp
+++ b/lldb/source/Core/ConnectionFileDescriptor.cpp
@@ -714,6 +714,12 @@ ConnectionFileDescriptor::Write (const void *src, size_t src_len, ConnectionStat
// - The Apple specific version allows for unlimited fds in the fd_sets by
// setting the _DARWIN_UNLIMITED_SELECT define prior to including the
// required header files.
+// CONS:
+// - on non-Apple platforms, only supports file descriptors up to FD_SETSIZE.
+// This implementation will assert if it runs into that hard limit to let
+// users know that another ConnectionFileDescriptor::BytesAvailable() should
+// be used or a new version of ConnectionFileDescriptor::BytesAvailable()
+// should be written for the system that is running into the limitations.
#if defined(__APPLE__)
#define FD_SET_DATA(fds) fds.data()
OpenPOWER on IntegriCloud