diff options
| author | Zachary Turner <zturner@google.com> | 2016-11-16 21:15:24 +0000 |
|---|---|---|
| committer | Zachary Turner <zturner@google.com> | 2016-11-16 21:15:24 +0000 |
| commit | c156427ded1dfa7686c90cc56ad16013a079a742 (patch) | |
| tree | f4912beeebd9e7a04e9c20a8e05d64e25bde192d /lldb/source/Commands/CommandObjectTarget.cpp | |
| parent | 725dc14bb21da8a01709a6b3370a658d071689dc (diff) | |
| download | bcm5719-llvm-c156427ded1dfa7686c90cc56ad16013a079a742.tar.gz bcm5719-llvm-c156427ded1dfa7686c90cc56ad16013a079a742.zip | |
Don't allow direct access to StreamString's internal buffer.
This is a large API change that removes the two functions from
StreamString that return a std::string& and a const std::string&,
and instead provide one function which returns a StringRef.
Direct access to the underlying buffer violates the concept of
a "stream" which is intended to provide forward only access,
and makes porting to llvm::raw_ostream more difficult in the
future.
Differential Revision: https://reviews.llvm.org/D26698
llvm-svn: 287152
Diffstat (limited to 'lldb/source/Commands/CommandObjectTarget.cpp')
| -rw-r--r-- | lldb/source/Commands/CommandObjectTarget.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp index fbf69d88bf0..a695589b4f8 100644 --- a/lldb/source/Commands/CommandObjectTarget.cpp +++ b/lldb/source/Commands/CommandObjectTarget.cpp @@ -2463,20 +2463,20 @@ protected: result.AppendErrorWithFormat( "Unable to create the executable or symbol file with " "UUID %s with path %s and symbol file %s", - strm.GetString().c_str(), + strm.GetData(), module_spec.GetFileSpec().GetPath().c_str(), module_spec.GetSymbolFileSpec().GetPath().c_str()); } else { result.AppendErrorWithFormat( "Unable to create the executable or symbol file with " "UUID %s with path %s", - strm.GetString().c_str(), + strm.GetData(), module_spec.GetFileSpec().GetPath().c_str()); } } else { result.AppendErrorWithFormat("Unable to create the executable " "or symbol file with UUID %s", - strm.GetString().c_str()); + strm.GetData()); } result.SetStatus(eReturnStatusFailed); return false; @@ -2486,7 +2486,7 @@ protected: module_spec.GetUUID().Dump(&strm); result.AppendErrorWithFormat( "Unable to locate the executable or symbol file with UUID %s", - strm.GetString().c_str()); + strm.GetData()); result.SetStatus(eReturnStatusFailed); return false; } @@ -4224,7 +4224,7 @@ protected: error_strm.PutCString( "unable to find debug symbols for the current frame"); } - result.AppendError(error_strm.GetData()); + result.AppendError(error_strm.GetString()); } } else { result.AppendError("one or more symbol file paths must be specified, " |
