diff options
author | Leonard Mosescu <mosescu@google.com> | 2018-05-02 20:06:17 +0000 |
---|---|---|
committer | Leonard Mosescu <mosescu@google.com> | 2018-05-02 20:06:17 +0000 |
commit | 9fecd37220578515775f1b5e724bd5932b26b08e (patch) | |
tree | 174de8e432dc25ac2277b58ceaff5e2faf1f28b2 /lldb/source/Commands/CommandObjectTarget.cpp | |
parent | fac26cf4ca4abd9142a4ed8939c167a6856f656e (diff) | |
download | bcm5719-llvm-9fecd37220578515775f1b5e724bd5932b26b08e.tar.gz bcm5719-llvm-9fecd37220578515775f1b5e724bd5932b26b08e.zip |
Use the UUID from the minidump's CodeView Record for placeholder modules
This change adds support for two types of Minidump CodeView records:
PDB70 (reference: https://crashpad.chromium.org/doxygen/structcrashpad_1_1CodeViewRecordPDB70.html)
This is by far the most common record type.
ELF BuildID (found in Breakpad/Crashpad generated minidumps)
This would set a proper UUID for placeholder modules, in turn enabling
an accurate match with local module images.
Differential Revision: https://reviews.llvm.org/D46292
llvm-svn: 331394
Diffstat (limited to 'lldb/source/Commands/CommandObjectTarget.cpp')
-rw-r--r-- | lldb/source/Commands/CommandObjectTarget.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp index 45204b6b0c2..ee7e0e914a2 100644 --- a/lldb/source/Commands/CommandObjectTarget.cpp +++ b/lldb/source/Commands/CommandObjectTarget.cpp @@ -1386,6 +1386,10 @@ static size_t DumpModuleObjfileHeaders(Stream &strm, ModuleList &module_list) { ObjectFile *objfile = module->GetObjectFile(); if (objfile) objfile->Dump(&strm); + else { + strm.Format("No object file for module: {0:F}\n", + module->GetFileSpec()); + } } } strm.IndentLess(); |