diff options
author | Pavel Labath <labath@google.com> | 2017-10-31 10:56:03 +0000 |
---|---|---|
committer | Pavel Labath <labath@google.com> | 2017-10-31 10:56:03 +0000 |
commit | 7263f1bda695772732c5a8ddbed2d07713a7e59c (patch) | |
tree | 57f62e5fddb72b7aca0e9410f53d1e5f49b20210 /lldb/source/Commands/CommandObjectPlatform.cpp | |
parent | 64f53b42144e36820a6a56c5fc08d1f5d4ded9bd (diff) | |
download | bcm5719-llvm-7263f1bda695772732c5a8ddbed2d07713a7e59c.tar.gz bcm5719-llvm-7263f1bda695772732c5a8ddbed2d07713a7e59c.zip |
Invert ArchSpec<->Platform dependency
Summary:
ArchSpec::SetTriple was taking a Platform as an argument, and used it to
fill in missing pieces of the specified triple. I invert the dependency
by moving this code to other classes. For this purpose, I've created
three new functions.
- HostInfo::GetAugmentedArchSpec: fills in the triple using the host
platform (this used to be implemented by passing a null platform
pointer). By putting this code in the Host module, we can provide a
way to anyone who does not have a platform instance (lldb-server) an
easy way to get Host data.
- Platform::GetAugmentedArchSpec: if you have a platform instance, you
can call this to let it fill in the triple.
- static Platform::GetAugmentedArchSpec: implements the "if platform ==
0 then use_host() else use_platform()" part.
Reviewers: zturner, jingham, clayborg
Subscribers: mgorny, javed.absar, lldb-commits
Differential Revision: https://reviews.llvm.org/D39387
llvm-svn: 316987
Diffstat (limited to 'lldb/source/Commands/CommandObjectPlatform.cpp')
-rw-r--r-- | lldb/source/Commands/CommandObjectPlatform.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/source/Commands/CommandObjectPlatform.cpp b/lldb/source/Commands/CommandObjectPlatform.cpp index 8003ae88ac0..8ed003767d5 100644 --- a/lldb/source/Commands/CommandObjectPlatform.cpp +++ b/lldb/source/Commands/CommandObjectPlatform.cpp @@ -1337,8 +1337,8 @@ protected: PlatformSP platform_sp = debugger_sp ? debugger_sp->GetPlatformList().GetSelectedPlatform() : PlatformSP(); - match_info.GetProcessInfo().GetArchitecture().SetTriple( - option_arg, platform_sp.get()); + match_info.GetProcessInfo().GetArchitecture() = + Platform::GetAugmentedArchSpec(platform_sp.get(), option_arg); } break; case 'n': |