diff options
author | Greg Clayton <gclayton@apple.com> | 2010-09-29 01:12:09 +0000 |
---|---|---|
committer | Greg Clayton <gclayton@apple.com> | 2010-09-29 01:12:09 +0000 |
commit | 1be10fca5f2b290b956710d9c03c14b0c82f7ef4 (patch) | |
tree | 4036af6f55e00076d5e2a9ee849bbcf628a39277 /lldb/source/Commands/CommandObjectImage.cpp | |
parent | edd4b600f3016b1ef1c3e39c3f495c524f600fa5 (diff) | |
download | bcm5719-llvm-1be10fca5f2b290b956710d9c03c14b0c82f7ef4.tar.gz bcm5719-llvm-1be10fca5f2b290b956710d9c03c14b0c82f7ef4.zip |
Fixed the forward declaration issue that was present in the DWARF parser after
adding methods to C++ and objective C classes. In order to make methods, we
need the function prototype which means we need the arguments. Parsing these
could cause a circular reference that caused an assertion.
Added a new typedef for the clang opaque types which are just void pointers:
lldb::clang_type_t. This appears in lldb-types.h.
This was fixed by enabling struct, union, class, and enum types to only get
a forward declaration when we make the clang opaque qual type for these
types. When they need to actually be resolved, lldb_private::Type will call
a new function in the SymbolFile protocol to resolve a clang type when it is
not fully defined (clang::TagDecl::getDefinition() returns NULL). This allows
us to be a lot more lazy when parsing clang types and keeps down the amount
of data that gets parsed into the ASTContext for each module.
Getting the clang type from a "lldb_private::Type" object now takes a boolean
that indicates if a forward declaration is ok:
clang_type_t lldb_private::Type::GetClangType (bool forward_decl_is_ok);
So function prototypes that define parameters that are "const T&" can now just
parse the forward declaration for type 'T' and we avoid circular references in
the type system.
llvm-svn: 115012
Diffstat (limited to 'lldb/source/Commands/CommandObjectImage.cpp')
-rw-r--r-- | lldb/source/Commands/CommandObjectImage.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Commands/CommandObjectImage.cpp b/lldb/source/Commands/CommandObjectImage.cpp index 8c17221b9a7..30e9195e9fd 100644 --- a/lldb/source/Commands/CommandObjectImage.cpp +++ b/lldb/source/Commands/CommandObjectImage.cpp @@ -429,7 +429,7 @@ LookupTypeInModule { // Resolve the clang type so that any forward references // to types that haven't yet been parsed will get parsed. - type_sp->GetOpaqueClangQualType (); + type_sp->GetClangType (); type_sp->GetDescription (&strm, eDescriptionLevelFull, true); } strm.EOL(); |