diff options
| author | Greg Clayton <gclayton@apple.com> | 2012-02-21 00:09:25 +0000 |
|---|---|---|
| committer | Greg Clayton <gclayton@apple.com> | 2012-02-21 00:09:25 +0000 |
| commit | 1ac04c308832f7a9b2e07e360f07c82f7cb2a02c (patch) | |
| tree | bb908a56f1d08a946f4f25aa7b4b762066e1ec57 /lldb/source/Commands/CommandObjectBreakpointCommand.cpp | |
| parent | 3508a0054301ef24b8d8619351788698bcd97620 (diff) | |
| download | bcm5719-llvm-1ac04c308832f7a9b2e07e360f07c82f7cb2a02c.tar.gz bcm5719-llvm-1ac04c308832f7a9b2e07e360f07c82f7cb2a02c.zip | |
Thread hardening part 3. Now lldb_private::Thread objects have std::weak_ptr
objects for the backlink to the lldb_private::Process. The issues we were
running into before was someone was holding onto a shared pointer to a
lldb_private::Thread for too long, and the lldb_private::Process parent object
would get destroyed and the lldb_private::Thread had a "Process &m_process"
member which would just treat whatever memory that used to be a Process as a
valid Process. This was mostly happening for lldb_private::StackFrame objects
that had a member like "Thread &m_thread". So this completes the internal
strong/weak changes.
Documented the ExecutionContext and ExecutionContextRef classes so that our
LLDB developers can understand when and where to use ExecutionContext and
ExecutionContextRef objects.
llvm-svn: 151009
Diffstat (limited to 'lldb/source/Commands/CommandObjectBreakpointCommand.cpp')
| -rw-r--r-- | lldb/source/Commands/CommandObjectBreakpointCommand.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lldb/source/Commands/CommandObjectBreakpointCommand.cpp b/lldb/source/Commands/CommandObjectBreakpointCommand.cpp index 7283e6d0e99..a7e98eaf06b 100644 --- a/lldb/source/Commands/CommandObjectBreakpointCommand.cpp +++ b/lldb/source/Commands/CommandObjectBreakpointCommand.cpp @@ -799,7 +799,8 @@ CommandObjectBreakpointCommand::BreakpointOptionsCallbackFunction if (commands.GetSize() > 0) { - Target *target = context->exe_ctx.GetTargetPtr(); + ExecutionContext exe_ctx (context->exe_ctx_ref); + Target *target = exe_ctx.GetTargetPtr(); if (target) { CommandReturnObject result; @@ -817,7 +818,7 @@ CommandObjectBreakpointCommand::BreakpointOptionsCallbackFunction bool print_results = true; debugger.GetCommandInterpreter().HandleCommands (commands, - &(context->exe_ctx), + &exe_ctx, stop_on_continue, data->stop_on_error, echo_commands, |
