Convert many functions to use StringRefs.

Where possible, remove the const char* version.  To keep the
risk and impact here minimal, I've only done the simplest
functions.

In the process, I found a few opportunities for adding some
unit tests, so I added those as well.

Tested on Windows, Linux, and OSX.

llvm-svn: 281799

1 files changed, 14 insertions, 7 deletions

diff --git a/lldb/source/Breakpoint/BreakpointID.cpp b/lldb/source/Breakpoint/BreakpointID.cpp
index 9ab7adf48c4..c237b22ec1d 100644
--- a/lldb/source/Breakpoint/BreakpointID.cpp
+++ b/lldb/source/Breakpoint/BreakpointID.cpp
@@ -107,14 +107,21 @@ bool BreakpointID::ParseCanonicalReference(const char *input,
   return false;
 }
 
-bool BreakpointID::StringIsBreakpointName(const char *name, Error &error) {
+bool BreakpointID::StringIsBreakpointName(llvm::StringRef str, Error &error) {
   error.Clear();
+  if (str.empty())
+    return false;
 
-  if (name && (name[0] >= 'A' && name[0] <= 'z')) {
-    if (strcspn(name, ".- ") != strlen(name)) {
-      error.SetErrorStringWithFormat("invalid breakpoint name: \"%s\"", name);
-    }
-    return true;
-  } else
+  // First character must be a letter or _
+  if (!isalpha(str[0]) || str[0] != '_')
+    return false;
+
+  // Cannot contain ., -, or space.
+  if (str.find_first_of(".- ") != llvm::StringRef::npos) {
+    error.SetErrorStringWithFormat("invalid breakpoint name: \"%s\"",
+                                   str.str().c_str());
     return false;
+  }
+
+  return true;
 }