Make ValueObject::SetValueFromCString work correctly.

Also change the SourceInitFile to look for .lldb-<APPNAME> and source that
preferentially if it exists.
Also made the breakpoint site report its address as well as its breakpoint number
when it gets hit and can't find any the associated locations (usually because the
breakpoint got disabled or deleted programmatically between the time it was hit
and reported.)
Changed ThreadPlanCallFunction to initialize the ivar m_func in the initializers of the
constructor, rather than waiting to initialize till later on in the function.
Fixed a bug where if you make an SBError and the ask it Success, it returns false.
Fixed ValueObject::ResolveValue so that it resolves a temporary value, rather than
overwriting the one in the value object.

llvm-svn: 137536

3 files changed, 10 insertions, 1 deletions

diff --git a/lldb/source/API/SBDebugger.cpp b/lldb/source/API/SBDebugger.cpp
index 35a66ae55d0..827892453a0 100644
--- a/lldb/source/API/SBDebugger.cpp
+++ b/lldb/source/API/SBDebugger.cpp
@@ -149,6 +149,13 @@ SBDebugger::SkipLLDBInitFiles (bool b)
         m_opaque_sp->GetCommandInterpreter().SkipLLDBInitFiles (b);
 }
 
+void
+SBDebugger::SkipAppInitFiles (bool b)
+{
+    if (m_opaque_sp)
+        m_opaque_sp->GetCommandInterpreter().SkipAppInitFiles (b);
+}
+
 // Shouldn't really be settable after initialization as this could cause lots of problems; don't want users
 // trying to switch modes in the middle of a debugging session.
 void
diff --git a/lldb/source/API/SBError.cpp b/lldb/source/API/SBError.cpp
index bcbb734cea7..d4827175761 100644
--- a/lldb/source/API/SBError.cpp
+++ b/lldb/source/API/SBError.cpp
@@ -86,7 +86,7 @@ bool
 SBError::Success () const
 {
     LogSP log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
-    bool ret_value = false;
+    bool ret_value = true;
     if (m_opaque_ap.get())
         ret_value = m_opaque_ap->Success();
 
diff --git a/lldb/source/API/SBValue.cpp b/lldb/source/API/SBValue.cpp
index 58eb9794729..a7bc91d958a 100644
--- a/lldb/source/API/SBValue.cpp
+++ b/lldb/source/API/SBValue.cpp
@@ -629,6 +629,7 @@ SBValue::GetValueForExpressionPath(const char* expr_path)
 int64_t
 SBValue::GetValueAsSigned(SBError& error, int64_t fail_value)
 {
+    error.Clear();
     if (m_opaque_sp)
     {
         if (m_opaque_sp->GetUpdatePoint().GetTargetSP())
@@ -650,6 +651,7 @@ SBValue::GetValueAsSigned(SBError& error, int64_t fail_value)
 uint64_t
 SBValue::GetValueAsUnsigned(SBError& error, uint64_t fail_value)
 {
+    error.Clear();
     if (m_opaque_sp)
     {
         if (m_opaque_sp->GetUpdatePoint().GetTargetSP())