APIs to GetValueAsSigned/Unsigned() in SBValue now also accept an SBError parameter to give more info about any problem

The synthetic children providers now use the new (safer) APIs to get the values of objects
As a side effect, fixed an issue in ValueObject where ResolveValue() was not always updating the value before reading it

llvm-svn: 136861

1 files changed, 42 insertions, 0 deletions

diff --git a/lldb/source/API/SBValue.cpp b/lldb/source/API/SBValue.cpp
index d874cc2fabc..820121132ee 100644
--- a/lldb/source/API/SBValue.cpp
+++ b/lldb/source/API/SBValue.cpp
@@ -619,6 +619,48 @@ SBValue::GetValueForExpressionPath(const char* expr_path)
 }
 
 int64_t
+SBValue::GetValueAsSigned(SBError& error, int64_t fail_value)
+{
+    if (m_opaque_sp)
+    {
+        if (m_opaque_sp->GetUpdatePoint().GetTargetSP())
+        {
+            Mutex::Locker api_locker (m_opaque_sp->GetUpdatePoint().GetTargetSP()->GetAPIMutex());
+            Scalar scalar;
+            if (m_opaque_sp->ResolveValue (scalar))
+                return scalar.GetRawBits64(fail_value);
+            else
+                error.SetErrorString("could not get value");
+        }
+        else
+            error.SetErrorString("could not get target");
+    }
+    error.SetErrorString("invalid SBValue");
+    return fail_value;
+}
+
+uint64_t
+SBValue::GetValueAsUnsigned(SBError& error, uint64_t fail_value)
+{
+    if (m_opaque_sp)
+    {
+        if (m_opaque_sp->GetUpdatePoint().GetTargetSP())
+        {
+            Mutex::Locker api_locker (m_opaque_sp->GetUpdatePoint().GetTargetSP()->GetAPIMutex());
+            Scalar scalar;
+            if (m_opaque_sp->ResolveValue (scalar))
+                return scalar.GetRawBits64(fail_value);
+            else
+                error.SetErrorString("could not get value");
+        }
+        else
+            error.SetErrorString("could not get target");
+    }
+    error.SetErrorString("invalid SBValue");
+    return fail_value;
+}
+
+int64_t
 SBValue::GetValueAsSigned(int64_t fail_value)
 {
     if (m_opaque_sp)